Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile - Support cuda12.8 for Blackwell arch #682

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

dpower4
Copy link
Contributor

@dpower4 dpower4 commented Jan 29, 2025

Description
Updated docker for 12.8
Use cutlass latest relase 3.8 with ARCH 100(blackwell) support
add latest nccl-test release with ARCH 100(blackwell)
Updated msccl to support build for sm_100
No breaking changes, so backward compatible tested with 12.4(for now)

@dpower4 dpower4 marked this pull request as ready for review January 29, 2025 22:17
@dpower4 dpower4 requested a review from a team as a code owner January 29, 2025 22:17
Copy link
Contributor

@polarG polarG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified this PR locally.

@dpower4 dpower4 force-pushed the feat/GB_12_8_build branch from d963ad8 to 6a51193 Compare February 4, 2025 18:43
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.67%. Comparing base (48cd8a3) to head (3ee480e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #682   +/-   ##
=======================================
  Coverage   85.67%   85.67%           
=======================================
  Files          99       99           
  Lines        7211     7211           
=======================================
  Hits         6178     6178           
  Misses       1033     1033           
Flag Coverage Δ
cpu-python3.10-unit-test 71.37% <ø> (ø)
cpu-python3.12-unit-test 71.37% <ø> (ø)
cpu-python3.7-unit-test 71.34% <ø> (ø)
cuda-unit-test 83.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dpower4 dpower4 requested review from polarG and abuccts February 25, 2025 19:17
@dpower4 dpower4 requested a review from polarG March 7, 2025 20:11
Copy link
Contributor

@polarG polarG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +237 to +242
$(eval ARCHS := 75 80 86 89 90 100)
if [ -d msccl ]; then rm -rf msccl; fi; \
git clone --single-branch --branch main https://github.com/Azure/msccl.git \
&& git -C msccl checkout 87048bd && git -C msccl submodule update --recursive --init
else ifeq ($(shell echo $(CUDA_VER)">=11.8" | bc -l), 1)
$(eval ARCHS := 70 75 80 86 89 90)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may only need 80, 90, and 100 archs for build, didn't test on the rest

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Building for the ARCH's for which cuda version supports. Will be helpful if someone wants to use this container on a 75 arch.

On the side: condensing the list will definitely help reduce the overall build time.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I mean we didn't test msccl on V100 (75 arch), A10 (86 arch) etc. so it may not work

@abuccts abuccts changed the title add docker build with cuda12.8 for blackwell support Dockerfile - Support cuda12.8 for Blackwell arch Mar 15, 2025
@abuccts abuccts added the containers SuperBench Containers label Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
containers SuperBench Containers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants