Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/CD - Update label in the ROCm image build #693

Merged
merged 6 commits into from
Mar 12, 2025

Conversation

polarG
Copy link
Contributor

@polarG polarG commented Mar 8, 2025

Due to the matrix strategy’s default "fail-fast" setting. In GitHub Actions, when running a job with a matrix, the individual configurations run in parallel. By default, if one matrix job (for example, the one labeled "rocm6_2_rocm6_2_x_superbe") fails, the remaining parallel jobs are canceled automatically.

In our current build image pipeline, the arm64 build job always are canceled by the rocm build job. So, using a non-existent label in the job config to prevent rocm build job from scheduling for a temporary solution.

@polarG polarG added the CI/CD Continuous integration or deployment label Mar 8, 2025
@polarG polarG requested a review from a team as a code owner March 8, 2025 02:19
@polarG polarG changed the title CI/CD: In build images, disable the feature that one build job fail will cancel other running jobs CI/CD: In build images, disable the default action config that one build job fail will cancel other running jobs Mar 8, 2025
Copy link

codecov bot commented Mar 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.67%. Comparing base (5e32859) to head (27962af).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #693   +/-   ##
=======================================
  Coverage   85.67%   85.67%           
=======================================
  Files          99       99           
  Lines        7211     7211           
=======================================
  Hits         6178     6178           
  Misses       1033     1033           
Flag Coverage Δ
cpu-python3.10-unit-test 71.37% <ø> (ø)
cpu-python3.12-unit-test 71.37% <ø> (ø)
cpu-python3.7-unit-test 71.34% <ø> (ø)
cuda-unit-test 83.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@polarG polarG changed the title CI/CD: In build images, disable the default action config that one build job fail will cancel other running jobs CI/CD: Disable the ROCM image build job Mar 8, 2025
@polarG polarG changed the title CI/CD: Disable the ROCM image build job CI/CD: Remove the ROCM image build job Mar 8, 2025
hongtaozhang added 2 commits March 10, 2025 15:44
…github.com:microsoft/superbenchmark into hongtaozhang/enhancement-decouple-build-image-jobs
@polarG polarG enabled auto-merge (squash) March 11, 2025 17:08
Copy link
Member

@abuccts abuccts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls update the title/description accordingly as well

@polarG polarG changed the title CI/CD: Remove the ROCM image build job CI/CD: Apply a non-existent label in the ROCM image building job configuration to prevent scheduling Mar 12, 2025
@abuccts abuccts disabled auto-merge March 12, 2025 20:45
@abuccts abuccts changed the title CI/CD: Apply a non-existent label in the ROCM image building job configuration to prevent scheduling CI/CD - Update label in the ROCm image build Mar 12, 2025
@polarG polarG merged commit 48cd8a3 into main Mar 12, 2025
20 of 21 checks passed
@polarG polarG deleted the hongtaozhang/enhancement-decouple-build-image-jobs branch March 12, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Continuous integration or deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants