Add display name and icon to SUI extensions page #18633
Conversation
Demo
|
|
|
||
| std::wstring_view PowershellCoreProfileGenerator::GetIcon() const noexcept | ||
| { | ||
| return POWERSHELL_ICON; |
There was a problem hiding this comment.
This icon doesn't look that great since I'm resizing it to make it bigger:
Is there a better resource I can use here?
|
|
||
| std::wstring_view WslDistroGenerator::GetIcon() const noexcept | ||
| { | ||
| return IconPath; |
There was a problem hiding this comment.
This icon doesn't look that great since I'm resizing it to make it bigger:
Is there a better resource I can use here?
|
|
||
| std::wstring_view SshHostGenerator::GetIcon() const noexcept | ||
| { | ||
| return _getProfileIconPath(); |
There was a problem hiding this comment.
Haven't tested this one since the generator is disabled by a feature flag, but I assume it doesn't look to great since I'm resizing. Same question as the others: is there a better resource I can use here?
| @@ -28,6 +28,8 @@ namespace winrt::Microsoft::Terminal::Settings::Model | |||
| public: | |||
| static std::wstring_view Namespace; | |||
| std::wstring_view GetNamespace() const noexcept override; | |||
| std::wstring_view GetDisplayName() const noexcept override; | |||
| std::wstring_view GetIcon() const noexcept override { return {}; }; | |||
There was a problem hiding this comment.
The only icons I found here were one for PowerShell and one for CMD. Can we get a Visual Studio asset for here?
| @@ -25,6 +25,8 @@ namespace winrt::Microsoft::Terminal::Settings::Model | |||
| { | |||
| public: | |||
| std::wstring_view GetNamespace() const noexcept override; | |||
| std::wstring_view GetDisplayName() const noexcept override; | |||
| std::wstring_view GetIcon() const noexcept override { return {}; }; | |||
There was a problem hiding this comment.
Surprised there's no icon here! Can we get one for Azure Cloud Shell?
| <!-- | ||
| BODGY | ||
| Theoretically, you could use a ContentTemplateSelector directly. However, that doesn't work. | ||
| For some reason, we just get the object type's ToString called and the selector gets nullptr as a parameter. | ||
| Adding the template as a view model property is a workaround. | ||
| --> |
There was a problem hiding this comment.
📝 FYI, I spent like most of today figuring out how to work around this. Frustrating 😡
| @@ -119,17 +119,19 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation | |||
| _extensionsVM = *extensionsVMImpl; | |||
| _extensionsViewModelChangedRevoker = _extensionsVM.PropertyChanged(winrt::auto_revoke, [=](auto&&, const PropertyChangedEventArgs& args) { | |||
| const auto settingName{ args.PropertyName() }; | |||
| if (settingName == L"CurrentExtensionSource") | |||
There was a problem hiding this comment.
📝 All the changes in this file are really just because I switched from CurrentExtensionSource to CurrentExtensionPackage. Honestly, it's better this way imo. It aligns better with how the New Tab Menu works as well as the other subpages for profiles
| @@ -42,7 +42,6 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation | |||
| WINRT_OBSERVABLE_PROPERTY(Editor::NewTabMenuViewModel, ViewModel, _PropertyChangedHandlers, nullptr); | |||
|
|
|||
| private: | |||
| Editor::NewTabMenuEntryTemplateSelector _entryTemplateSelector{ nullptr }; | |||
There was a problem hiding this comment.
📝Drive by. We weren't using it at all.
|
CC @nguyen-dows and @DHowett for some of the questions above. Y'all may know where I can find some of these assets |
carlos-zamora
force-pushed
the
dev/cazamor/sui/extensions-page
branch
from
ec88b32 to
7cdbb7c
Compare
carlos-zamora
force-pushed
the
dev/cazamor/sui/ext-page/beautify
branch
from
f780523 to
cb04e7f
Compare
Summary of the Pull Request
Adds some polish to the Extensions page in the Settings UI. This includes:
References and Relevant Issues
Targets #18559
Detailed Description of the Pull Request / Additional comments
DisplayNameandIcontoIDynamicProfileGeneratorDisplayNameandIconfrom app extensions and use themExtensionPackageis a new WinRT class to package a bunch ofFragmentSettingstogetherExtensionPackages rather than dynamically adding/removingFragmentSettings contentsCurrentExtensionSourcewithCurrentExtensionPackageExtensionPackageTemplateSelectoris used to displayExtensionPackages with metadata vs simple ones that just have a sourceValidation
✅ Keyboard navigation feels right
✅ Screen reader reads all info on screen properly
✅ Accessibility Insights FastPass found no issues
✅ "Discard changes" retains subpage, but removes any changes