Fix bugs introduced in #18623 #18635
Open
+24
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
added
Issue-Bug
DHowett
reviewed
Feb 27, 2025
| if ( | ||
| _messageBoxCount <= 0 && | ||
| _windowCount <= 0 && | ||
| !_app.Logic().Settings().GlobalSettings().AllowHeadless()) |
There was a problem hiding this comment.
between the lines... does this mean that wt --help when headless mode is enabled will leave one running?
There was a problem hiding this comment.
Yes. I think that's an edge case worth solving later (or not at all?).
DHowett
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic didn't work when persistence was enabled and you had 2 windows and closed the 2nd one, or when dragging the last tab out of the only window.
Validation Steps Performed