Skip to content

Update FontInfoDesired.hpp #19434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update FontInfoDesired.hpp #19434

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 24 additions & 13 deletions src/renderer/inc/FontInfoDesired.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ Author(s):
- Michael Niksa (MiNiksa) 17-Nov-2015
--*/


#ifndef FONT_INFO_DESIRED_HPP
#define FONT_INFO_DESIRED_HPP

#pragma once

#include "FontInfoBase.hpp"
Expand All @@ -30,27 +34,34 @@ class FontInfoDesired : public FontInfoBase
const unsigned int weight,
const float fontSize,
const unsigned int uiCodePage) noexcept;
FontInfoDesired(const FontInfo& fiFont) noexcept;
explicit FontInfoDesired(const FontInfo& fiFont) noexcept;

// Deleted comparison operator to avoid accidental equality checks
bool operator==(const FontInfoDesired& other) const = delete;

bool operator==(const FontInfoDesired& other) = delete;

void SetCellSize(const CSSLengthPercentage& cellWidth, const CSSLengthPercentage& cellHeight) noexcept;
void SetEnableBuiltinGlyphs(bool builtinGlyphs) noexcept;
void SetEnableColorGlyphs(bool colorGlyphs) noexcept;

const CSSLengthPercentage& GetCellWidth() const noexcept;
const CSSLengthPercentage& GetCellHeight() const noexcept;
bool GetEnableBuiltinGlyphs() const noexcept;
bool GetEnableColorGlyphs() const noexcept;
float GetFontSize() const noexcept;
til::size GetEngineSize() const noexcept;
bool IsDefaultRasterFont() const noexcept;
// Getters (nodiscard prevents ignored important values)
[[nodiscard]] const CSSLengthPercentage& GetCellWidth() const noexcept;
[[nodiscard]] const CSSLengthPercentage& GetCellHeight() const noexcept;
[[nodiscard]] bool GetEnableBuiltinGlyphs() const noexcept;
[[nodiscard]] bool GetEnableColorGlyphs() const noexcept;
[[nodiscard]] float GetFontSize() const noexcept;
[[nodiscard]] til::size GetEngineSize() const noexcept;
[[nodiscard]] bool IsDefaultRasterFont() const noexcept;

// Destructor (only needed if polymorphism is expected)
~FontInfoDesired() override = default;

private:
til::size _coordSizeDesired;
float _fontSize;
til::size _coordSizeDesired{}; // initialized to default (0,0)
float _fontSize{ 0.0f }; // safe default
CSSLengthPercentage _cellWidth;
CSSLengthPercentage _cellHeight;
bool _builtinGlyphs = false;
bool _colorGlyphs = true;
bool _builtinGlyphs{ false };
bool _colorGlyphs{ true };
};