Update bundled nuget.exe to 7.6.0 and refresh CLI build guidance - #20400
Open
steven-pribilinskiy wants to merge 1 commit into
Open
Update bundled nuget.exe to 7.6.0 and refresh CLI build guidance#20400steven-pribilinskiy wants to merge 1 commit into
steven-pribilinskiy wants to merge 1 commit into
Conversation
The command-line build path had quietly rotted: - dep/nuget/nuget.exe was v4.1 (2017), which cannot parse the .slnx solution, so Invoke-OpenConsoleBuild failed at restore. Updated to v7.6.0; both restore steps the build scripts perform now succeed. - doc/building.md opened by telling people to init git submodules this repository does not have, documented Debug-only AppPackages paths, hardcoded a 19041 SDK makeappx path, and pointed at a VS 2022 Preview DeployAppRecipe path. Removed/updated those, added a prerequisites pointer to the README (VS 2026 / v145 toolset requirement), and added a troubleshooting section covering the failure modes a stale toolchain actually produces (old-nuget .slnx error, vcpkg v145 message, WMC9999 XAML compiler crash, PCH out-of-memory errors and the reduced-parallelism workaround). - README now links to doc/building.md from Building the Code. Refs microsoft#5541, microsoft#16379, microsoft#17880 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
4 tasks
Author
|
more than a week and this PR is still in review |
This comment was marked as low quality.
This comment was marked as low quality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Follow-up to the discussion in #20390 (request from @zadjii-msft): updates the CLI build guidance to match current reality, and upgrades the bundled
dep/nuget/nuget.exefrom 4.1.0 (2017) to 7.6.0 as @DHowett suggested.Detailed Description of the Pull Request / Additional comments
dep/nuget/nuget.exe4.1.0 → 7.6.0. The old binary predates.slnxsupport, soInvoke-OpenConsoleBuildfailed at its first step withInvalid input 'OpenConsole.slnx'. The file type was not recognized.With 7.6.0, both restore invocations intools/OpenConsole.psm1succeed unchanged (verified locally against a cleanmaincheckout).doc/building.md:git submodule update --init --recursive— the repository has no.gitmodules(one of the confusions reported in Please update building documentation #17880)..slnxnot recognized;Unable to find a valid Visual Studio instance ... with toolset version v145;Xaml Internal Error WMC9999on untouched sources (this one cost me a day on Allow choosing separate light & dark color schemes in the Settings UI #20390 — it gives no hint the fix is a newer VS);C3859/C1076out-of-memory failures (and the MSB8084 hang) → reduced-parallelism workaround/m:2 /p:CL_MPCount=2.AppPackagesfolder/msix names only carry the_Debuginfix for Debug builds, removed the cmd variant that hardcoded a10.0.19041.0makeappx path (the PowerShell variant is canonical), replaced the hardcodedVS 2022 PreviewDeployAppRecipe.exepath with%VSINSTALLDIR%, and noted the registered dev package launches aswtd.exe.README.md: the Building the Code section now links todoc/building.mdfor the deploy walkthrough and troubleshooting.Validation Steps Performed
dep\nuget\nuget.exe restore OpenConsole.slnxandrestore dep\nuget\packages.config(the two callsInvoke-OpenConsoleBuildmakes) exit 0 with the new binary.OpenConsole.slnx+ msix unpack/register/launch of the dev package completed on this machine (VS 2026 Community 18.7, Windows 11) as part of validating Allow choosing separate light & dark color schemes in the Settings UI #20390 — the troubleshooting entries are the failures actually hit and resolved along the way.Refs #5541, #16379, #17880
🤖 Generated with Claude Code