Skip to content

Add right-click context menu to open settings folder in Explorer #20439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
smz202000 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add right-click context menu to open settings folder in Explorer #20439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/cascadia/TerminalSettingsEditor/MainPage.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,6 +452,11 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation
}
}


void MainPage::OpenSettingsFolder_Click(const IInspectable& /*sender*/, const Windows::UI::Xaml::RoutedEventArgs& /*args*/)
{
OpenJson.raise(nullptr, SettingsTarget::Directory);
}
void MainPage::_PreNavigateHelper()
{
_profileViewModelChangedRevoker.revoke();
Expand Down
1 change: 1 addition & 0 deletions src/cascadia/TerminalSettingsEditor/MainPage.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation
void SaveButton_Click(const Windows::Foundation::IInspectable& sender, const Windows::UI::Xaml::RoutedEventArgs& args);
void ResetButton_Click(const Windows::Foundation::IInspectable& sender, const Windows::UI::Xaml::RoutedEventArgs& args);
void BreadcrumbBar_ItemClicked(const Microsoft::UI::Xaml::Controls::BreadcrumbBar& sender, const Microsoft::UI::Xaml::Controls::BreadcrumbBarItemClickedEventArgs& args);
void OpenSettingsFolder_Click(const Windows::Foundation::IInspectable& sender, const Windows::UI::Xaml::RoutedEventArgs& args);

void SetHostingWindow(uint64_t hostingWindow) noexcept;
bool TryPropagateHostingWindow(IInspectable object) noexcept;
Expand Down
13 changes: 12 additions & 1 deletion src/cascadia/TerminalSettingsEditor/MainPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,18 @@
<muxc:NavigationViewItem x:Name="OpenJsonNavItem"
x:Uid="Nav_OpenJSON"
SelectsOnInvoked="False"
Tag="OpenJson_Nav" />
Tag="OpenJson_Nav" >
<muxc:NavigationViewItem.ContextFlyout>
<MenuFlyout>
<MenuFlyoutItem x:Uid="Nav_OpenSettingsFolder"
Click="OpenSettingsFolder_Click">
<MenuFlyoutItem.Icon>
<FontIcon Glyph="&#xE838;" />
</MenuFlyoutItem.Icon>
</MenuFlyoutItem>
</MenuFlyout>
</muxc:NavigationViewItem.ContextFlyout>
</muxc:NavigationViewItem>
</muxc:NavigationView.FooterMenuItems>

<Grid>
Expand Down
4 changes: 4 additions & 0 deletions src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,6 +689,10 @@
<value>Open JSON file</value>
<comment>Header for a menu item. This opens the JSON file that is used to log the app's settings.</comment>
</data>
<data name="Nav_OpenSettingsFolder.Text" xml:space="preserve">
<value>Open settings folder</value>
<comment>Header for a context menu item. This opens the parent folder of the settings.json file in File Explorer.</comment>
</data>
<data name="Nav_ProfileDefaults.Content" xml:space="preserve">
<value>Defaults</value>
<comment>Header for the "defaults" menu item. This navigates to a page that lets you see and modify settings that affect profiles. This is the lowest layer of profile settings that all other profile settings are based on. If a profile doesn't define a setting, this page is responsible for figuring out what that setting is supposed to be.</comment>
Expand Down
Loading