Add "micaAlt" as a value for the useMica theme option - #20464
Add "micaAlt" as a value for the useMica theme option#20464JayPatel095 wants to merge 12 commits into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
@microsoft-github-policy-service agree |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This comment has been minimized.
This comment has been minimized.
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
JayPatel095
changed the title
|
@zadjii-msft Mind starting CI? |
|
/azp |
Supported commands
See additional documentation. |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 20464 in repo microsoft/terminal |
|
@JayPatel095 we mind starting CI before doing a review, yes, because the purpose of delaying CI is to prevent people from modifying the pipeline and compromising the build agent. I see that you tried two times to interact with the azure pipelines bot, over the weekend when nobody would be around to watch. Should we be concerned? |
I'm a bit confused, since I only interacted with the bot 3 hours ago, as in this morning, specifically after 9. Otherwise it was just basic lint and the policy agreement. As in my only direct attempt to start CI was today, and otherwise it was a request to someone experienced enough to tell me if I was missing something or needed to wait, like how I now know you guys aren't CI-first. So, I don't really think there is an issue here. |
|
ah, misread :) |
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). 1 pipeline(s) were filtered out due to trigger conditions. |
|
|
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). 1 pipeline(s) were filtered out due to trigger conditions. |
|
@DHowett Any next steps regarding review? |
3 participants
Summary of the Pull Request
Adds a
"micaAlt"option touseMicausing a string enum rather than a boolean (like the old system). Backward compat is maintained with the boolean values which is limited to using or not using mica w/o micaAlt.References and Relevant Issues
Closes #17650
Detailed Description of the Pull Request / Additional comments
The old
useMicawas a boolean mapping toDWMSBT_MAINWINDOWorDWMSBT_NONE. This adds a third state forDWMSBT_TABBEDWINDOW, doing the same thing asCloseOnExitModeandbellStyle(boolean to enum).To do this, the new
MicaStyleenum was added in Theme.idl, a JSON_ENUM_WRAPPER for MicaStyle was added to TerminalSettingsSerializationHelpers.h with an override for booleans, various refactoring changes from boolean->enum, and some tests. Doc repo has ready-to-merge PR as well, mirroring the changes tocloseOnExitrather thanbellStyle, MicrosoftDocs/terminal#969.No settings UI added, stays JSON-only.
Validation Steps Performed
Compiled on 25H2 Pro VM but transparent effects don't render over RDP -> sideloaded onto VMWare with 3D effects enabled -> took images below.
PR Checklist
old, false(no mica)old, true(mica)new, "none"(no mica)new, "mica"(mica)new, "micaAlt"(micaAlt)