Fix globalSummon with monitor:any moving to wrong monitor when desktop:toCurrent - #20485
Open
Criseda wants to merge 1 commit into
Open
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Author
|
@microsoft-github-policy-service agree |
Criseda
marked this pull request as ready for review
July 30, 2026 17:01
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
When
globalSummonis invoked withmonitor:anyanddesktop:toCurrent,MoveWindowToDesktopmay reposition the window to the monitor of the current foreground window instead of keeping it on its original monitor. This fix saves the window position before summoning and restores it after the desktop move completes.References and Relevant Issues
Closes #20305
Detailed Description of the Pull Request / Additional comments
In
AppHost::HandleSummon, when the combination ofMonitorBehavior::InPlace(mapped frommonitor:any) andMoveToCurrentDesktop=trueis detected:SummonWindowMoveWindowToDesktopruns on the background thread, dispatch back to the UI thread and compare the current window origin to the saved originMoveWindowToDesktopmoved the window to a different monitor), restore the saved position viaSetWindowPosThe
HWNDhandle is also extracted once at the top and reused throughout as a minor cleanup.This approach was previously suggested by contributor @Weichenleeeee123 in the issue comments.
Validation Steps Performed
Invoke-CodeFormatPR Checklist
globalSummonwith"monitor": "any"behaves as"monitor": "toCurrent"#20305