Add support for STA thread #2682
Merged
+611
−125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When run with MSTest runner, when on Windows and the user specifies `ExecutionApartmentState` entry in the runsettings and the current thread is not already in the right state, we now create a global thread that switches to the requested apartment state. When run on VSTest, we rely on VSTest setting the right global state. The test method execution is also fixed for .NET Core to rely on thread when we need to be on STA thread.
Evangelink
commented
Apr 9, 2024
src/Adapter/MSTestAdapter.PlatformServices/Services/ThreadOperations.cs
Outdated
Show resolved
Hide resolved
src/Adapter/MSTestAdapter.PlatformServices/Services/ThreadOperations.cs
Outdated
Show resolved
Hide resolved
Evangelink
commented
Apr 9, 2024
src/Adapter/MSTest.TestAdapter/TestingPlatformAdapter/MSTestBridgedTestFramework.cs
Outdated
Show resolved
Hide resolved
src/Adapter/MSTestAdapter.PlatformServices/Services/ThreadOperations.cs
Outdated
Show resolved
Hide resolved
Evangelink
commented
Apr 10, 2024
src/Adapter/MSTest.TestAdapter/TestingPlatformAdapter/MSTestBridgedTestFramework.cs
Outdated
Show resolved
Hide resolved
Evangelink
commented
Apr 10, 2024
src/Adapter/MSTest.TestAdapter/TestingPlatformAdapter/MSTestBridgedTestFramework.cs
Outdated
Show resolved
Hide resolved
MarcoRossignoli
previously approved these changes
Apr 11, 2024
src/Adapter/MSTest.TestAdapter/PublicAPI/PublicAPI.Unshipped.txt
Outdated
Show resolved
Hide resolved
MarcoRossignoli
previously approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When run with MSTest runner, when on Windows and the user specifies
ExecutionApartmentStateentry in the runsettings and the current thread is not already in the right state, we now create a global thread that switches to the requested apartment state.When run on VSTest, we rely on VSTest setting the right global state.
The test method execution is also fixed for .NET Core to rely on thread when we need to be on STA thread.
Contributes to #1674