Fix MSTEST0002 (Test classes should have valid layout) codefix crash on records

src/Analyzers/MSTest.Analyzers.CodeFixes/TestClassShouldBeValidFixer.cs

@@ -47,7 +47,7 @@ public override async Task RegisterCodeFixesAsync(CodeFixContext context)
             return;
         }
 
-        ClassDeclarationSyntax declaration = syntaxToken.Parent.AncestorsAndSelf().OfType<ClassDeclarationSyntax>().FirstOrDefault();
+        TypeDeclarationSyntax declaration = syntaxToken.Parent.AncestorsAndSelf().OfType<TypeDeclarationSyntax>().First();
 
         // Register a code action that will invoke the fix.
         context.RegisterCodeFix(
@@ -58,7 +58,7 @@ public override async Task RegisterCodeFixesAsync(CodeFixContext context)
             diagnostic);
     }
 
-    private static async Task<Document> FixClassDeclarationAsync(Document document, ClassDeclarationSyntax classDeclaration, CancellationToken cancellationToken)
+    private static async Task<Document> FixClassDeclarationAsync(Document document, TypeDeclarationSyntax typeDeclaration, CancellationToken cancellationToken)
     {
         cancellationToken.ThrowIfCancellationRequested();
 
@@ -70,9 +70,9 @@ private static async Task<Document> FixClassDeclarationAsync(Document document,
 
         // Remove the static modifier if it exists
         SyntaxTokenList modifiers = SyntaxFactory.TokenList(
-            classDeclaration.Modifiers.Where(modifier => !modifier.IsKind(SyntaxKind.StaticKeyword)));
+            typeDeclaration.Modifiers.Where(modifier => !modifier.IsKind(SyntaxKind.StaticKeyword)));
 
-        if (!classDeclaration.Modifiers.Any(SyntaxKind.PublicKeyword))
+        if (!typeDeclaration.Modifiers.Any(SyntaxKind.PublicKeyword))
         {
             // Determine the visibility modifier
             SyntaxToken visibilityModifier = canDiscoverInternals
@@ -84,8 +84,8 @@ private static async Task<Document> FixClassDeclarationAsync(Document document,
         }
 
         // Create a new class declaration with the updated modifiers.
-        ClassDeclarationSyntax newClassDeclaration = classDeclaration.WithModifiers(modifiers);
-        editor.ReplaceNode(classDeclaration, newClassDeclaration);
+        TypeDeclarationSyntax newTypeDeclaration = typeDeclaration.WithModifiers(modifiers);
+        editor.ReplaceNode(typeDeclaration, newTypeDeclaration);
         SyntaxNode newRoot = editor.GetChangedRoot();
 
         return document.WithSyntaxRoot(newRoot);

test/UnitTests/MSTest.Analyzers.UnitTests/TestClassShouldBeValidAnalyzerTests.cs

@@ -54,6 +54,35 @@ await VerifyCS.VerifyCodeFixAsync(
             fixedCode);
     }
 
+    [TestMethod]
+    public async Task WhenClassIsInternalAndTestRecord_Diagnostic()
+    {
+        string code = """
+            using Microsoft.VisualStudio.TestTools.UnitTesting;
+
+            [TestClass]
+            internal record {|#0:MyTestClass|}
+            {
+            }
+            """;
+
+        string fixedCode = """
+            using Microsoft.VisualStudio.TestTools.UnitTesting;
+
+            [TestClass]
+            public record MyTestClass
+            {
+            }
+            """;
+
+        await VerifyCS.VerifyCodeFixAsync(
+            code,
+            VerifyCS.Diagnostic(TestClassShouldBeValidAnalyzer.TestClassShouldBeValidRule)
+                .WithLocation(0)
+                .WithArguments("MyTestClass"),
+            fixedCode);
+    }
+
     [DataRow("private")]
     [DataRow("internal")]
     [TestMethod]