Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move away from nuspec for MSTest metapackage #4818

Merged
merged 11 commits into from
Feb 4, 2025
Merged

Move away from nuspec for MSTest metapackage #4818

merged 11 commits into from
Feb 4, 2025

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Jan 29, 2025 •
edited
Loading

Fixes #4736
Fixes #4663

@Youssef1313 Youssef1313 force-pushed the nuspec-metapackage branch 3 times, most recently from 6a261a7 to 1fcf0ee Compare January 29, 2025 05:24
@Youssef1313 Youssef1313 mentioned this pull request Jan 31, 2025
Closed
@Youssef1313 Youssef1313 mentioned this pull request Feb 4, 2025
Closed
@Youssef1313 Youssef1313 marked this pull request as ready for review February 4, 2025 05:32
Evangelink
Evangelink reviewed Feb 4, 2025
View reviewed changes
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Microsoft.NET.Test.Sdk still working as expected following this change? It's not using buildTransitive:
image

@Youssef1313
Copy link
Member Author

Ah, interesting! Thanks for catching this @Evangelink.

I'll need to check

@Youssef1313
Copy link
Member Author

@Evangelink That was indeed a real untested issue. Fixed and ensured it's tested.

@Evangelink Evangelink merged commit 13331af into microsoft:main Feb 4, 2025
8 checks passed
@Youssef1313 Youssef1313 deleted the nuspec-metapackage branch February 4, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evangelink Evangelink Evangelink approved these changes

Assignees
No one assigned
Labels
Area: WinUI
Projects
None yet
Milestone
No milestone
2 participants
@Youssef1313 @Evangelink