Skip to content

Flaky test investigation #4987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Youssef1313 wants to merge 2 commits into from
Closed

Flaky test investigation #4987

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70f7c3b
Flaky test investigation
Youssef1313 Feb 12, 2025
dfd96b9
Merge branch 'main' into flaky-investigation
Evangelink Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/Adapter/MSTest.TestAdapter/Helpers/FixtureMethodRunner.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,8 +174,15 @@ internal static class FixtureMethodRunner
UnitTestOutcome.Timeout,
string.Format(CultureInfo.InvariantCulture, methodCanceledMessageFormat, methodInfo.DeclaringType!.FullName, methodInfo.Name));
}
catch (Exception)
catch (Exception ex)
{
if (ex is AggregateException aggregateEx && aggregateEx.InnerExceptions.OfType<TaskCanceledException>().Any(tce => tce.CancellationToken == cancellationTokenSource.Token))
{
return new(
UnitTestOutcome.Timeout,
"Are we going to hit this??");
}

// We throw the real exception to have the original stack trace to elaborate up the chain.
if (realException is not null)
{
Expand Down
Loading