Add InstanceId to communication with dotnet test #5279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tance-id-to-dotnet-test
mariam-abdulla
changed the title
Youssef1313
previously approved these changes
Mar 20, 2025
…//github.com/microsoft/testfx into dev/mabdullah/add-instance-id-to-dotnet-test
Youssef1313
approved these changes
Mar 20, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5279 +/- ##
==========================================
- Coverage 76.08% 73.64% -2.45%
==========================================
Files 601 601
Lines 36368 36392 +24
==========================================
- Hits 27672 26800 -872
- Misses 8696 9592 +896
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the ability to run
dotnet testusing the Microsoft Testing Platform, enhancing the testing experience while maintaining backward compatibility. The main changes include adding anInstanceIdto various classes and methods to uniquely identify test instances and updating the serialization and deserialization processes to handle this new property.Enhancements to Testing Platform:
InstanceIdproperty to theDotnetTestConnectionclass to uniquely identify test instances. (src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/DotnetTestConnection.cs)IsCompatibleProtocolAsyncmethod to includeInstanceIdin the handshake message. (src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/DotnetTestConnection.cs)Serialization and Deserialization Updates:
InstanceIdto theHandshakeMessagePropertyNamesand corresponding classes to handle the new property in messages. (src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/IPC/Constants.cs)DiscoveredTestMessages,FileArtifactMessages, andTestResultMessagesto includeInstanceIdand modified their serializers to handle the new property. (src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/IPC/Models/DiscoveredTestMessages.cs,src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/IPC/Models/FileArtifactMessages.cs,src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/IPC/Models/TestResultMessages.cs) [1] [2] [3]Documentation:
dotnet testwith the Microsoft Testing Platform, including motivation, proposed solution, and configuration details. (docs/RFCs/011-Sdk-Testing-Platform.md)