Skip to content

Use abstraction over EqtTrace on platform services#7266

Closed
Evangelink wants to merge 2 commits intomainfrom
dev/amauryleve/logger
Closed

Use abstraction over EqtTrace on platform services#7266
Evangelink wants to merge 2 commits intomainfrom
dev/amauryleve/logger

Conversation

@Evangelink
Copy link
Member

Fixes #2140

@Evangelink Evangelink marked this pull request as ready for review January 20, 2026 19:52
@Evangelink Evangelink enabled auto-merge January 20, 2026 19:52
@Evangelink
Copy link
Member Author

Locally the test TestDataSourceFromAppConfig consistently fails, I can repro doing it inside the playground. There is a crash at the end of the lambda of TestMethodRunner. I haven't been able to diagnose why it's failing but it seems the error doesn't appear in CI.

@Youssef1313
Copy link
Member

Youssef1313 commented Jan 21, 2026

I can repro locally. Looks like a native crash (access violation) in C:\Program Files\Common Files\Microsoft Shared\Office16\mso98win32client.dll.

Unhandled exception at 0x00007FFD5880BADB (mso98win32client.dll) in DataSourceTests.exe_260121_121807.dmp: 0xC0000005: Access violation reading location 0x0000000000004DE1.

Dump is captured by procdump -ma -e -x . DataSourceTests.exe

@Evangelink
Copy link
Member Author

Closing as we will go with changes from Youssef in #7271 and #7277

@Evangelink Evangelink closed this Jan 22, 2026
auto-merge was automatically disabled January 22, 2026 17:24

Pull request was closed

@Evangelink Evangelink deleted the dev/amauryleve/logger branch January 22, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use logger interface and not EqtTrace logger

2 participants