Fix extensionless files missing from [Content_Types].xml manifest #525
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
genContentTypesXml()method only processed files from VsixManifestBuilder's own collection (this.files), excluding files added by other manifest builders like VsoManifestBuilder. This caused extensionless executables and other files to be missing from the Content_Types.xml Override section, breaking digital signing tools.Changes
genContentTypesXml()to accept and process the mergedpackageFilesparameter containing all files from all buildersfinalize()to pass the merged file collection togenContentTypesXml()Before:
After:
This ensures all package files receive proper Override elements in [Content_Types].xml, regardless of which builder added them.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
03nvsblobprodwcus014.vsblob.vsassets.io/usr/local/bin/node node /usr/local/bin/npm install 53 -j ACCEPT js(dns block)055vsblobprodwcus02.vsblob.vsassets.io/usr/local/bin/node node /usr/local/bin/npm install 53 -j ACCEPT js(dns block)1g1vsblobprodwcus01.vsblob.vsassets.io/usr/local/bin/node node /usr/local/bin/npm install 53 -j ACCEPT js(dns block)3eavsblobprodwcus03.vsblob.vsassets.io/usr/local/bin/node node /usr/local/bin/npm install 53 -j ACCEPT js(dns block)3zgvsblobprodwcus024.vsblob.vsassets.io/usr/local/bin/node node /usr/local/bin/npm install 53 -j ACCEPT js(dns block)40qvsblobprodwcus022.vsblob.vsassets.io/usr/local/bin/node node /usr/local/bin/npm install 53 -j ACCEPT js(dns block)4fdvsblobprodwcus012.vsblob.vsassets.io/usr/local/bin/node node /usr/local/bin/npm install 53 -j ACCEPT js(dns block)5tbvsblobprodwcus06.vsblob.vsassets.io/usr/local/bin/node node /usr/local/bin/npm install 53 -j ACCEPT js(dns block)61cvsblobprodwcus010.vsblob.vsassets.io/usr/local/bin/node node /usr/local/bin/npm install 53 -j ACCEPT js(dns block)73dvsblobprodwcus07.vsblob.vsassets.io/usr/local/bin/node node /usr/local/bin/npm install 53 -j ACCEPT js(dns block)8usvsblobprodwcus011.vsblob.vsassets.io/usr/local/bin/node node /usr/local/bin/npm install 53 -j ACCEPT js(dns block)9owvsblobprodwcus020.vsblob.vsassets.io/usr/local/bin/node node /usr/local/bin/npm install 53 -j ACCEPT js(dns block)arpvsblobprodwcus017.vsblob.vsassets.io/usr/local/bin/node node /usr/local/bin/npm install 53 -j ACCEPT js(dns block)crcvsblobprodwcus021.vsblob.vsassets.io/usr/local/bin/node node /usr/local/bin/npm install 53 -j ACCEPT js(dns block)fslvsblobprodwcus015.vsblob.vsassets.io/usr/local/bin/node node /usr/local/bin/npm install 53 -j ACCEPT js(dns block)grnvsblobprodwcus04.vsblob.vsassets.io/usr/local/bin/node node /usr/local/bin/npm install 53 -j ACCEPT js(dns block)k92vsblobprodwcus08.vsblob.vsassets.io/usr/local/bin/node node /usr/local/bin/npm install 53 -j ACCEPT js(dns block)mnzvsblobprodwcus05.vsblob.vsassets.io/usr/local/bin/node node /usr/local/bin/npm install 53 -j ACCEPT js(dns block)pl8vsblobprodwcus09.vsblob.vsassets.io/usr/local/bin/node node /usr/local/bin/npm install 53 -j ACCEPT js(dns block)uubvsblobprodwcus018.vsblob.vsassets.io/usr/local/bin/node node /usr/local/bin/npm install 53 -j ACCEPT js(dns block)vwmvsblobprodwcus016.vsblob.vsassets.io/usr/local/bin/node node /usr/local/bin/npm install 53 -j ACCEPT js(dns block)x4wvsblobprodwcus013.vsblob.vsassets.io/usr/local/bin/node node /usr/local/bin/npm install 53 -j ACCEPT js(dns block)xg1vsblobprodwcus019.vsblob.vsassets.io/usr/local/bin/node node /usr/local/bin/npm install 53 -j ACCEPT js(dns block)xlkvsblobprodwcus023.vsblob.vsassets.io/usr/local/bin/node node /usr/local/bin/npm install 53 -j ACCEPT js(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.