engineering: Add AZL4 distro detection and extend GRUB path to AZL4#642
Open
Britel wants to merge 3 commits into
Open
engineering: Add AZL4 distro detection and extend GRUB path to AZL4#642Britel wants to merge 3 commits into
Britel wants to merge 3 commits into
Conversation
Britel
force-pushed
the
user/britel/azl4-1-grub-native
branch
5 times, most recently
from
33d33ac to
701a853
Compare
Britel
changed the title
bfjelds
reviewed
May 29, 2026
Britel
force-pushed
the
user/britel/azl4-1-grub-native
branch
2 times, most recently
from
a5460e9 to
2da4ab6
Compare
Implements AzureLinuxRelease::AzL4 variant, VERSION_ID 4.x parsing, ID_LIKE=fedora matching, updated GRUB match arms for AzL3|AzL4, and image_distro() fallback to host os-release. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Britel
force-pushed
the
user/britel/azl4-1-grub-native
branch
from
2da4ab6 to
49b6d9b
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Azure Linux 4.0 (AzL4) recognition in os-release parsing and wires that into the GRUB update flow so installs can target AzL4 correctly (including when the installer host OS differs from the image OS).
Changes:
- Extend
OsRelease::get_distro()/Distrohelpers to recognizeVERSION_ID=4.xasAzureLinuxRelease::AzL4, plus add AzL4 sample os-release data for tests. - Switch GRUB update selection to key off the image distro, and allow the existing AzL3 GRUB update path to run for AzL4 as well.
- Update mkinitrd functional-test initramfs glob to handle AzL4 naming (
*.azl4.img).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/trident/src/engine/context/mod.rs | Adds image_distro() logic to prefer image os-release with fallback to host. |
| crates/trident/src/engine/boot/grub.rs | Uses ctx.image_distro() and extends GRUB update support to AzL4. |
| crates/osutils/src/testutils/osrelease.rs | Adds mock AZL4 /etc/os-release content for tests. |
| crates/osutils/src/osrelease.rs | Adds AzL4 detection, enum variant, and unit test coverage for parsing. |
| crates/osutils/src/mkinitrd.rs | Adds AzL4 initramfs naming pattern for functional tests. |
image_distro() was falling back to the host os-release whenever the image's distro was Distro::Other. This silently masked unrecognized distros as the host distro, causing GRUB config to be written for the wrong OS. Now: if an image is mounted (self.image.is_some()), always use the image's distro. Fallback to host only fires when no image is present at all (functional tests, runtime operations). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The function now serves both AZL3 and AZL4. Remove version-specific references from the doc comment and debug log messages. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds AZL4 (Azure Linux 4.0, Fedora-based) distro detection and wires it into the GRUB update flow so installs can target AZL4 correctly, including when the installer host OS differs from the image OS.
Changes
OsRelease::get_distro()/Distrohelpers to recognizeVERSION_ID=4.xasAzureLinuxRelease::AzL4, plusID_LIKE=fedoradetectionis_azl4()helper onDistroimage_distro(), and allow the existing GRUB update path to run for AZL4 as wellimage_distro()falls back to host OS only when no image is mounted (not when distro is unrecognized)update_grub_config_azl3toupdate_grub_config(serves both AZL3 and AZL4)PR Stack