Skip to content

Enable 1D tensor support for enableMakeGatherScatterTensorPtr #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Brandon Myers (bmyerz0) merged 4 commits into from
Aug 27, 2025
Merged

Enable 1D tensor support for enableMakeGatherScatterTensorPtr #321

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
44363f1
Enable 1D tensor support for enableMakeGatherScatterTensorPtr
Aug 14, 2025
2275741
Add a smaller test.
Aug 14, 2025
78ab249
Add test for addptr and if.
Aug 26, 2025
fe4fdb5
Add test for loop as XFAIL.
Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions lib/AnalysisStructured/PtrAnalysis.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1217,10 +1217,6 @@ LogicalResult PtrAnalysis::rewriteAddptrOp(triton::AddPtrOp op) {
auto maketptrOp = state.createTTSMakeTensorPtrOp(builder, op.getLoc());
ptrMap.map(op.getResult(), maketptrOp.getResult());
} else if (enableMakeGatherScatterTensorPtr) {
// If there is only one dimension, return failure since there are no
// continuous dimensions.
if (state.getRank() == 1)
return failure();
PtrState unstructuredState;
// Switch to unstructured state analysis to create offsets and strides
// for the non-structured dimension.
Expand Down
Loading