The content after @defaultValue should remain on the same line #427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spike-rabbit
requested review from
D4N14L,
apostolisms,
dmichon-msft,
iclanton,
octogonz and
patmill
as code owners
Contributor
Author
|
@microsoft-github-policy-service agree |
D4N14L
approved these changes
Sep 12, 2024
Member
|
Looks good to me, but will likely need @octogonz review before merge |
Contributor
Author
D4N14L
previously approved these changes
Oct 2, 2024
common/changes/@microsoft/tsdoc/default-value-inline-content_2024-09-12-09-25.json
Outdated
Show resolved
Hide resolved
Member
|
@octogonz will need to merge the PR. I know he's been quite busy lately but hopefully he sees this. |
Contributor
Author
|
@octogonz would be really nice to have this merged. Can you please do a review here. |
Member
|
@spike-rabbit I've ping'd him on Zulip, which is where he's usually available. Hopefully this will help get some traction here. |
octogonz
approved these changes
May 28, 2025
Collaborator
|
@spike-rabbit FYI we are working on publishing your fix, but there's an issue with the CI pipeline for this repo. Thanks for your patience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fixing the issue described in #426