This repository was archived by the owner on Jun 11, 2020. It is now read-only.
Reference the same files as the compiler - #774
Open
Jack Bates (jablko) wants to merge 1 commit into
Open
Conversation
Jack Bates (jablko)
requested review from
Ryan Cavanaugh (RyanCavanaugh) and
Nathan Shively-Sanders (sandersn)
as code owners
April 28, 2020 23:50
6 tasks
Jack Bates (jablko)
force-pushed
the
patch-7
branch
from
May 8, 2020 17:07
5583c10 to
5ace83b
Compare
Nathan Shively-Sanders (sandersn)
suggested changes
Jun 9, 2020
Nathan Shively-Sanders (sandersn)
left a comment
Member
There was a problem hiding this comment.
Same comment as your other fixes. Can you add a test for this, and port it to microsoft/DefinitelyTyped-tools?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
types-publisher always resolves non-relative imports relative to the current older-version directory, e.g.
import { createRenderer } from 'react-test-renderer/shallow';->types/react-test-renderer/v15/shallow/index.d.ts. This implies a"react-test-renderer/*": ["react-test-renderer/v15/*"]path mapping, or the compiler will look in the latest-package directory instead (types/react-test-renderer/shallow/index.d.ts).This PR ensures that the path mapping is there. The error is roughly cribbed from
types-publisher/src/lib/definition-parser.ts
Lines 383 to 388 in dd69e3b