update peer dependencies for openapi3 emitter #6666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skywing918
requested review from
bterlson,
markcowl,
allenjzhang,
timotheeguerin,
witemple-msft,
chrisradek and
AlitzelMendez
as code owners
microsoft-github-policy-service
bot
added
the
emitter:openapi3
|
vscode extension needs to know the rest library is expected. |
timotheeguerin
requested changes
Mar 25, 2025
| "@typespec/versioning": "workspace:^" | ||
| "@typespec/versioning": "workspace:^", | ||
| "@typespec/rest": "workspace:^", | ||
| "@typespec/tspd": "workspace:^", |
There was a problem hiding this comment.
Tspd is a dev depedency that's not even published
| @@ -69,7 +69,10 @@ | |||
| "@typespec/http": "workspace:^", | |||
| "@typespec/json-schema": "workspace:^", | |||
| "@typespec/openapi": "workspace:^", | |||
| "@typespec/versioning": "workspace:^" | |||
| "@typespec/versioning": "workspace:^", | |||
| "@typespec/rest": "workspace:^", | |||
There was a problem hiding this comment.
can you explain more why rest is expected it is not a dependency? it is not used in any of openapi3 code.
|
I believe these are being added because of #6664 - but the solution shouldn't be to add every library that might be used by the target TypeSpec file as a peer dependency of openapi3. openapi3 should only include libraries it depends on as peerDependencies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add all dev dependencies starting with @typespec into peer dependencies.