Skip to content

http-client-java, bug fix, spread of optional body #7044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

weidongxu-microsoft
Copy link
Contributor

@weidongxu-microsoft weidongxu-microsoft commented Apr 18, 2025

  1. bug fix for the spread/flatten of the request body, which is flagged by TCGC as optional (when all properties be optional)
    Test case 670e652
  2. a minor refactor on addImports, to keep the imports in the Parameter when it relates to the Parameter (files in model/clientmodel)

@weidongxu-microsoft weidongxu-microsoft changed the title http-client-java, fix spread of optional body http-client-java, bug fix, spread of optional body Apr 18, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the emitter:client:java Issue for the Java client emitter: @typespec/http-client-java label Apr 18, 2025
Copy link
Contributor

No changes needing a change description found.

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 🛝 VSCode Extension

Copy link
Member

@anuchandy anuchandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Weidong!

@weidongxu-microsoft
Copy link
Contributor Author

The behavior change in TCGC would be reverted, as #1907 so it is not expected to have spread + optional body.

@weidongxu-microsoft weidongxu-microsoft added this pull request to the merge queue Apr 21, 2025
Merged via the queue into microsoft:main with commit 816a232 Apr 21, 2025
25 checks passed
@weidongxu-microsoft weidongxu-microsoft deleted the http-client-java_fix-spread-optional-body branch April 21, 2025 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emitter:client:java Issue for the Java client emitter: @typespec/http-client-java
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants