-
Notifications
You must be signed in to change notification settings - Fork 292
ClientMethodTemplate: Remove method parameters that can be obtained from other parameters and Improve ClientType to WireType function #7483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
No changes needing a change description found. |
You can try these changes here
|
...in/java/com/microsoft/typespec/http/client/generator/core/template/ClientMethodTemplate.java
Show resolved
Hide resolved
d8a2342
to
e73a408
Compare
...in/java/com/microsoft/typespec/http/client/generator/core/template/ClientMethodTemplate.java
Show resolved
Hide resolved
...in/java/com/microsoft/typespec/http/client/generator/core/template/ClientMethodTemplate.java
Outdated
Show resolved
Hide resolved
...in/java/com/microsoft/typespec/http/client/generator/core/template/ClientMethodTemplate.java
Show resolved
Hide resolved
…rom other parameters
…ar to the rest of the code in convertClientTypesToWireTypes
7912cb5
to
cff5f07
Compare
The changes look good to me.
|
Hi @haolingdong-msft , from my understanding:
There is a submodule commitId to set
Currently we trigger it manually. For validation on Swagger part, it's more convenient than preparing a PR in autorest.java repository.
I believe this part hasn't been changed. Weidong and Anu may provide more context on this. |
To Haoling, the verification pipeline is mostly for convenience. It takes a commitId or a branch. For PR that we do need a new release, or need version bump on dependencies, or sync of tests, one probably would just go there and create a PR on autorest.java But for task like refactor, that pipeline could be a help. |
ClientMethodTemplate
(and its extended types) methods, there is no need to passProxyMethod
as an explicit argument, since it can be obtained fromClientMethod
argument.List<ProxyMethodParameter>
explicitly when it can be obtained fromClientMethod ::ProxyMethod::parameters
convertClientTypesToWireTypes
has been simplified and updated to be extensible for future prs that aim to simplify inherited templates such as client core.AutoRest validation pr.