Skip to content

Minmax value more types #8580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

Minmax value more types #8580

wants to merge 26 commits into from

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Sep 26, 2025 •
edited
Loading

fix #3318
fix #8476

Only carry over the infromation in openapi3 when the value is serialized as numeric(unixTimeStamp or seconds/milliseconds duration)

Copilot AI and others added 10 commits September 24, 2025 18:03
@Copilot
Initial plan
116dbdf
@Copilot @timotheeguerin
Add @minValue/@MaxValue support for datetime types
6fc0fce 
Co-authored-by: timotheeguerin <[email protected]>
@Copilot @timotheeguerin
Complete @minValue/@MaxValue datetime support with comprehensive testing
ffd7a03 
Co-authored-by: timotheeguerin <[email protected]>
@Copilot @timotheeguerin
Rename validation function and update error messages per review feedback
6d18bf0 
Co-authored-by: timotheeguerin <[email protected]>
@Copilot @timotheeguerin
Fix test constructors and add value validation per review feedback
b5c2c51 
Co-authored-by: timotheeguerin <[email protected]>
@Copilot @timotheeguerin
Changes before error encountered
8aab5c1 
Co-authored-by: timotheeguerin <[email protected]>
@Copilot @timotheeguerin
Fix unixTimestamp32 test to use fromISO constructor
0670d5b 
Co-authored-by: timotheeguerin <[email protected]>
@Copilot @timotheeguerin
Fix CI failures: remove unused function and update datetime tests to …
82cf960 
…use numeric values

Co-authored-by: timotheeguerin <[email protected]>
@timotheeguerin
progress
f8a72da
@timotheeguerin
fix
8f1b411
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 26, 2025 •
edited
Loading

All changed packages have been documented.

  • ✅ @typespec/compiler
  • ✅ @typespec/openapi3
  • ✅ @typespec/tspd
Show changes

@typespec/tspd - fix ✏️

Handle union of union correctly for target type in decorator signature generation

@typespec/compiler - feature ✏️

Add support for @minValue, @maxValue and their exclusive variant for datetime and duration types.,> Expose as well the following APIs,> - getMinValueForScalar,> - getMaxValueForScalar,> - getMinValueExclusiveForScalar,> - getMaxValueExclusiveForScalar

@typespec/openapi3 - feature ✏️

Add support for min/max value for date time and duration types

@azure-sdk
Copy link
Collaborator

azure-sdk commented Sep 26, 2025 •
edited
Loading

You can try these changes here

🛝 Playground 🌐 Website 🛝 VSCode Extension

@timotheeguerin timotheeguerin marked this pull request as ready for review September 26, 2025 19:51
markcowl
markcowl reviewed Sep 26, 2025
View reviewed changes
@timotheeguerin timotheeguerin mentioned this pull request Sep 29, 2025
Open
timotheeguerin
timotheeguerin commented Oct 6, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markcowl markcowl markcowl left review comments

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@witemple-msft witemple-msft Awaiting requested review from witemple-msft witemple-msft is a code owner

@chrisradek chrisradek Awaiting requested review from chrisradek chrisradek is a code owner

@AlitzelMendez AlitzelMendez Awaiting requested review from AlitzelMendez AlitzelMendez is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add @minValue/ @maxValue support for date time types Decorator @minValue, @maxValue to support scalar Duration

4 participants

@timotheeguerin @azure-sdk @markcowl @Copilot