Init Support for Family SAML21 #83
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmoskal
approved these changes
Nov 11, 2019
Contributor
mmoskal
left a comment
mmoskal
left a comment
There was a problem hiding this comment.
Looks good, modulo requested changes!
mmoskal
suggested changes
Nov 11, 2019
Contributor
mmoskal
left a comment
mmoskal
left a comment
There was a problem hiding this comment.
See comment above, meant to request changes
sabas1080
commented
Nov 11, 2019
Contributor
|
Let me know when you have tested on hardware! |
Closed
Contributor
Author
|
@mmoskal tested in hardware and ok! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi I have started the port for the SAML family
so far the UF2 file can be generated, but
-nostartfilesmust be removed in MakefilesI wait for your feedback, thanks
fixes #82