Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix curl creating download dir in 750 mode #1440

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix curl creating download dir in 750 mode #1440

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
455a21a
Fix curl creating download dir in 750 mode
moritz-h Jun 26, 2024
be30316
erge remote-tracking branch 'origin/main' into download-dir
BillyONeal Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/vcpkg/base/downloads.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -786,6 +786,10 @@ namespace vcpkg
}
}
#endif
// Create directory in advance, otherwise curl will create it in 750 mode on unix style file systems.
const auto dir = download_path_part_path.parent_path();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is the right thing, there are a lot of edge cases where just chopping off the last path element will do the wrong thing. Consider something like a/b/../out.exe.

fs.create_directories(dir, VCPKG_LINE_INFO);

auto cmd = Command{"curl"}
.string_arg("--fail")
.string_arg("-L")
Expand Down
Loading