Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output log files as collapsed sections in ci #1556

Merged
merged 8 commits into from
Jan 17, 2025
Merged

Output log files as collapsed sections in ci #1556

merged 8 commits into from
Jan 17, 2025
+189 −51

Conversation

autoantwort
Copy link
Contributor

Results in
image

@BillyONeal
Copy link
Member

I think this implements https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2152662 "Include logs in the console output for bad CI systems"

BillyONeal
BillyONeal requested changes Jan 9, 2025
View reviewed changes
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only true blocker is the localized text. I'm weakly against not reusing the CI detection in VcpkgCmdArguments. Everything else is nitpicks.

src/vcpkg/commands.build.cpp Outdated Show resolved Hide resolved
src/vcpkg/commands.build.cpp Outdated Show resolved Hide resolved
src/vcpkg/commands.build.cpp Outdated Show resolved Hide resolved
@JavierMatosD JavierMatosD marked this pull request as draft January 9, 2025 23:36
autoantwort and others added 3 commits January 14, 2025 15:33
@autoantwort
Merge branch 'main' into feature/ci-collapsible-logs
323f47f
@BillyONeal
Merge remote-tracking branch 'origin/main' into feature/ci-collapsibl…
a8c0356 
…e-logs
@BillyONeal
* Reuse CI detection from the telemetry part in vcpkgcmdarguments.
6e7a1aa 
* Set SECTION_NAME for GitLabCI to the alphaumericdots of the filename.
* Deduplicate some CI detection tests.
* Fix a *foo.get() pattern in create_user_troubleshooting_message.
BillyONeal
BillyONeal approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@BillyONeal BillyONeal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please confirm you are happy with the fixes I pushed in 6e7a1aa (edit: and 9c37d8b ) and mark 'Ready for review' if you are. Thanks!

@autoantwort autoantwort marked this pull request as ready for review January 16, 2025 14:04
@autoantwort
Copy link
Contributor Author

Thank you for implementing the suggestions. I forgot about this PR 😅

@BillyONeal BillyONeal enabled auto-merge (squash) January 17, 2025 19:58
@BillyONeal BillyONeal merged commit c7fd737 into microsoft:main Jan 17, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyONeal BillyONeal BillyONeal approved these changes

@JavierMatosD JavierMatosD JavierMatosD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@autoantwort @BillyONeal @JavierMatosD