Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the problem of prompting when downloading git with fetch command #1583

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jimwang118
Copy link
Contributor

@BillyONeal
Copy link
Member

I don't think we should ever be guessing the version from the file name of the downloaded file like this; instead the schema should be changed to distinguish between minimum acceptable version and 'the version in the download'. The easiest way to do that is probably to add 'minimum-version' because the 'version' field is referred to all over the place, such as in these messages.

@jimwang118
Copy link
Contributor Author

I don't think we should ever be guessing the version from the file name of the downloaded file like this; instead the schema should be changed to distinguish between minimum acceptable version and 'the version in the download'. The easiest way to do that is probably to add 'minimum-version' because the 'version' field is referred to all over the place, such as in these messages.

Should we add a field to record the downloaded version number ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[vcpkg-tool] vcpkg fetch should use correct version for folder names
2 participants