Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rework] Binary Cache: Add write-back support #1597

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fran6co
Copy link
Contributor

@fran6co fran6co commented Feb 12, 2025

Trying to implement #1406 with the new changes in the code

@fran6co fran6co marked this pull request as draft February 12, 2025 15:07
@fran6co fran6co force-pushed the fran/write_back branch 3 times, most recently from 6cab351 to 5edae6e Compare February 13, 2025 01:06
@fran6co fran6co changed the title [WIP][Rework] Binary Cache: Add write-back support [Rework] Binary Cache: Add write-back support Feb 13, 2025
@fran6co fran6co marked this pull request as ready for review February 13, 2025 01:18
@fran6co
Copy link
Contributor Author

fran6co commented Feb 13, 2025

I'm not sure I like the writeback option and I think it makes more sense like the original PR to write-back on every write provider given that we expect the package to be uploaded on build and to be there later on, so a write source not having a package it's more about being cleared at some point and I think it's expected to be refilled if marked as write

@fran6co
Copy link
Contributor Author

fran6co commented Feb 13, 2025

In any case, I think push_success should check if the package is there already to avoid uploading when it doesn't need to. I could add the check just on writeback, but is there a reason why it's set to overwrite on push_success even if the package is already there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant