Try to improve ubuntu test lab reliability #1617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillyONeal
force-pushed
the
git-ubuntu
branch
4 times, most recently
from
04739ed to
02ab9cd
Compare
| @@ -209,12 +209,12 @@ namespace vcpkg | |||
|
|
|||
| bool git_add_with_index(DiagnosticContext& context, const Path& git_exe, const Path& index_file, const Path& target) | |||
| { | |||
| Command cmd(git_exe); | |||
| cmd.string_arg("-c").string_arg("core.autocrlf=false").string_arg("-c").string_arg("core.untrackedCache=false"); | |||
| RedirectedProcessLaunchSettings launch_settings; | |||
There was a problem hiding this comment.
why remove core.untrackedCache=false?
There was a problem hiding this comment.
Because it didn't seem to actually fix the problem and it makes it slower
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR testing in #1616 passed twice but now CI is failing because git isn't detecting changes.
I don't know exactly why, but issuing a random
git statusafter editing the files seems to fix it. I'm guessing it's some sort of race on Ubuntu when mtime doesn't move forward by 1 second that is confusing git, which normally only has 1 second resolution; but I really have no idea.