Add x-test-features and format-feature-baseline
#802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tested instead of testing all "changed" ports
…ause the packages folder is deleted when a package fails
# Conflicts: # src/vcpkg/install.cpp
dg0yt
reviewed
Nov 13, 2022
# Conflicts: # src/vcpkg/commands.ci.cpp
…stall to resolve racy access to the packages directory." This reverts commit 2fbb847.
BillyONeal
added a commit
to BillyONeal/vcpkg-tool
that referenced
this pull request
Mar 5, 2025
... rather than attempting to rederive it several times. This clears the way for several actions that want to install the same package name with different feature sets (in microsoft#802 ) to not step on each others' toes.
... rather than attempting to rederive it several times. This clears the way for several actions that want to install the same package name with different feature sets (in microsoft#802 ) to not step on each others' toes.
…id an extra copy when it is unnecessary.
…fferent builds of the same package. Avoids different feature installs of the same package stomping on each other.
|
Tests are likely to fail without microsoft/vcpkg#44217 , but just pushed changes that remove the blocking. |
BillyONeal
changed the title
x-test-features and format-feature-baseline
* Shorten switch names to drop "feature-" and "-test" implied by the command name being "test-features" * Deduplicate switch names with contractual-constants.h * Deduplicate some other constants with contractual-constants.h * seperatly -> separately * Name optionals "maybe_" when potential conflict with the not optional version of the same thing applies. * (Drive by) Make null_build_logs_recorder a plain ref.
BillyONeal
approved these changes
Mar 7, 2025
There was a problem hiding this comment.
Please take a look at changes I pushed and let me know if they are OK.
The following are needed before this can merge:
Always use InstallPlanAction::package_dir #1604Allow vcpkg.exe to set CURRENT_ variables. vcpkg#44217(Billy to resurrect the docs PR tomorrow)
Thanks for the feature and sorry it took us forever to land it!
BillyONeal
added a commit
that referenced
this pull request
Mar 7, 2025
... rather than attempting to rederive it several times. This clears the way for several actions that want to install the same package name with different feature sets (in #802 ) to not step on each others' toes.
|
LGTM |
# Conflicts: # src/vcpkg/dependencies.cpp
|
Thanks again for the great, ahem, feature! Sorry it took us forever :( |
|
Docs PR resurrected microsoft/vcpkg-docs#455 |
|
It now fails with when I run |
You need microsoft/vcpkg#44217 |
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new command
x-test-features. It can be passed a list of port names or--allto specify for which ports the tests should be run.The following tests are performed:
--no-core)--no-separated)--no-combined)Feature which are unsupported or marked as cascade for the target triplet are skipped.
For every test only the necessary dependencies are installed (like vcpkg install in manifest mode).
The idea is to run the feature test for all ports that are changed by a PR.
Ports that cascade must be explicitly marked as cascade.
vcpkg format-feature-baseline scripts/ci.feature.baseline.txtis a command to format the feature baseline to enforce that all entries in a "block" are sorted alphabetically.Docs: microsoft/vcpkg-docs#131
Fixes microsoft/vcpkg#13119
#908 reduce the needed ci time, this PR increases it again. So the actual change is not likely to be very large.