[Libtomcrypt, libtommath] new ports - #10960
Merged
Robert Schumacher (ras0219-msft) merged 16 commits intoApr 27, 2020
Merged
Conversation
|
|
Chris Moore (crmoore)
changed the title
Lily (LilyWangL)
approved these changes
Apr 23, 2020
Contributor
|
Chris Moore (@crmoore) Thanks for your PR. Please sign the cla. |
Chris Moore (crmoore)
marked this pull request as ready for review
April 23, 2020 16:06
Lily (LilyWangL)
added
info:needs-maintainer-attention
Contributor
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update PR #8787 to support mac and linux and address comments there.
Fixes issue #10947, #10948, #10466
These triplets pass:
x86-windows
x64-windows
x64-uwp
x64-linux
x64-osx
These do not. I'm not sure why. baseline has been updated.
arm-uwp
arm64-windows
x64-windows-static
I'm a mac/linux guy, and am not setup to chase down issues on windows.