[qtbase] enable egl for android #35961
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LilyWangLL
added
the
category:port-feature
|
Please handle the build error on CI pipeline. |
m-kuhn
force-pushed
the
qtbase_android_egl
branch
from
d7cde63 to
661a541
Compare
m-kuhn
commented
Jan 3, 2024
| # Missing system libraries | ||
| qtwayland:x64-osx=fail | ||
| qtwayland:arm64-osx=fail | ||
| # Missing system libraries when pulled in as dependency for android | ||
| qtwayland:x64-linux=skip |
There was a problem hiding this comment.
Should be fixed by https://github.com/microsoft/vcpkg/pull/35961/files#diff-783e7bf9703fa77a2652b514ee607d8e40aafdd4f25f7e4e663de8b224f43e62R36 but I cannot prove it in this PR, as the docker image in use is a prebuilt one
There was a problem hiding this comment.
Suggested change
| qtwayland:x64-linux=skip |
|
@LilyWangLL this needs a change in the base docker image for the android ci pipeline. How can this be tested? |
|
Also needs changes to the ci, abandoning this one to have only one discussion at #35845. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable support for feature
eglforandroidforqtbase.Specifying it as default-feature for android but at the same time specifying the feature as not supported is inconsistent.
This actively expects
qtbase:*-androidto fail in CI, so far they were ignored because of the above-mentioned inconsistency.Branched off #35845 which is more complicated because it requests changes to the ci infrastructure.