Skip to content

Conversation

@m-kuhn
Copy link
Contributor

@m-kuhn m-kuhn commented Feb 12, 2024

Fixes #36698

On macos/linux a wrong include path is reported by python since #34888

./tools/python3/python3.11 -c "import pprint;import sysconfig; pprint.pprint(sysconfig.get_paths())"                                                                     
{'data': '/home/mkuhn/dev/vcpkg/installed/x64-linux',
 'include': '/home/mkuhn/dev/vcpkg/include/python3.11',
 'platinclude': '/home/mkuhn/dev/vcpkg/include/python3.11',
 'platlib': '/home/mkuhn/dev/vcpkg/installed/x64-linux/lib/python3.11/site-packages',
 'platstdlib': '/home/mkuhn/dev/vcpkg/installed/x64-linux/lib/python3.11',
 'purelib': '/home/mkuhn/dev/vcpkg/installed/x64-linux/lib/python3.11/site-packages',
 'scripts': '/home/mkuhn/dev/vcpkg/installed/x64-linux/bin',
 'stdlib': '/home/mkuhn/dev/vcpkg/installed/x64-linux/lib/python3.11'}

@Neumann-A
Copy link
Contributor

i wonder what exactly ${installed_base} is ?

'scripts': '/home/mkuhn/dev/vcpkg/installed/x64-linux/bin', is probably wrong and needs to be tools/python3

@m-kuhn
Copy link
Contributor Author

m-kuhn commented Feb 12, 2024

I wonder what exactly scripts is.
On windows it points to 'scripts': '{base}/Scripts' is that where the python3 executable is located?

@Neumann-A
Copy link
Contributor

On windows it points to 'scripts': '{base}/Scripts' is that where the python3 executable is located?

No its where all the additional binaries and scripts are located like pip or cython

@m-kuhn
Copy link
Contributor Author

m-kuhn commented Feb 12, 2024

Changing this has an effect on many python packages

E.g. it will install wheel into tools and then building setuptools will complain

2024-02-12 23:02:37,198 gpep517 INFO Building wheel via backend setuptools.build_meta
usage: __main__.py [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...]
   or: __main__.py --help [cmd1 cmd2 ...]
   or: __main__.py --help-commands
   or: __main__.py cmd --help

error: invalid command 'bdist_wheel'

I think we can look into adjusting this path also, but I'd prefer to defer this for now and stick to this simple fix

@Neumann-A
Copy link
Contributor

It has to be changed otherwise you need to manually move all the scripts. Also the tools/python3 needs to be on PATH so that everything in there can be found.

@m-kuhn
Copy link
Contributor Author

m-kuhn commented Feb 13, 2024

@Neumann-A
Copy link
Contributor

hmm I get

ERROR Missing dependencies:
	wheel

for some reason. ok let it be for now.

@data-queue data-queue merged commit 163fe24 into microsoft:master Feb 15, 2024
@m-kuhn m-kuhn deleted the py-non-win branch February 15, 2024 07:10
TomKatom pushed a commit to TomKatom/vcpkg that referenced this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

python reports wrong include dir on linux and macos

3 participants