-
Notifications
You must be signed in to change notification settings - Fork 7.2k
[usd] update to 24.11 #41864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[usd] update to 24.11 #41864
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
1529cfd
update to 24.11
jimwang118 047c078
update version
jimwang118 2e923e0
update to 24.11
jimwang118 4e709cc
update version
jimwang118 e3a46be
rename patch
jimwang118 811e784
update version
jimwang118 1819abc
remove usd from ci.baseline.txt
jimwang118 fdfa3a2
update version
jimwang118 bd3090e
reset ci.baseline.txt
jimwang118 6726b9c
update version
jimwang118 15f5358
fix build feature error
jimwang118 58758e4
update version
jimwang118 d120a7d
Merge branch 'master' into up-usd
jimwang118 301b2a3
modify patch
jimwang118 4e50fc2
update version
jimwang118 f1340dd
solved conflicts
jimwang118 597baa2
update version
jimwang118 cfd4814
update version
jimwang118 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,139 @@ | ||
| diff --git a/cmake/defaults/Packages.cmake b/cmake/defaults/Packages.cmake | ||
| index 1b69cad..9494278 100644 | ||
| --- a/cmake/defaults/Packages.cmake | ||
| +++ b/cmake/defaults/Packages.cmake | ||
| @@ -190,7 +190,8 @@ if (PXR_BUILD_IMAGING) | ||
| # --OpenImageIO | ||
| if (PXR_BUILD_OPENIMAGEIO_PLUGIN) | ||
| set(REQUIRES_Imath TRUE) | ||
| - find_package(OpenImageIO REQUIRED) | ||
| + find_package(OpenImageIO CONFIG REQUIRED) | ||
| + set(OIIO_LIBRARIES OpenImageIO::OpenImageIO) | ||
| add_definitions(-DPXR_OIIO_PLUGIN_ENABLED) | ||
| if (OIIO_idiff_BINARY) | ||
| set(IMAGE_DIFF_TOOL ${OIIO_idiff_BINARY} CACHE STRING "Uses idiff for image diffing") | ||
| @@ -227,6 +228,7 @@ if (PXR_BUILD_IMAGING) | ||
| find_package(Vulkan REQUIRED) | ||
| list(APPEND VULKAN_LIBS Vulkan::Vulkan) | ||
|
|
||
| + if(0) | ||
| # Find the extra vulkan libraries we need | ||
| set(EXTRA_VULKAN_LIBS shaderc_combined) | ||
| if (WIN32 AND CMAKE_BUILD_TYPE STREQUAL "Debug") | ||
| @@ -236,6 +238,7 @@ if (PXR_BUILD_IMAGING) | ||
| find_library("${EXTRA_LIBRARY}_PATH" NAMES "${EXTRA_LIBRARY}" PATHS $ENV{VULKAN_SDK}/lib) | ||
| list(APPEND VULKAN_LIBS "${${EXTRA_LIBRARY}_PATH}") | ||
| endforeach() | ||
| + endif() | ||
|
|
||
| # Find the OS specific libs we need | ||
| if (UNIX AND NOT APPLE) | ||
| @@ -249,10 +252,20 @@ if (PXR_BUILD_IMAGING) | ||
| else() | ||
| message(FATAL_ERROR "VULKAN_SDK not valid") | ||
| endif() | ||
| + find_package(unofficial-shaderc CONFIG REQUIRED) | ||
| + find_package(unofficial-spirv-reflect CONFIG REQUIRED) | ||
| + find_package(VulkanMemoryAllocator CONFIG REQUIRED) | ||
| + list(APPEND VULKAN_LIBS unofficial::shaderc::shaderc) | ||
| + list(APPEND VULKAN_LIBS unofficial::spirv-reflect) | ||
| + list(APPEND VULKAN_LIBS GPUOpen::VulkanMemoryAllocator) | ||
| endif() | ||
| # --Opensubdiv | ||
| - set(OPENSUBDIV_USE_GPU ${PXR_BUILD_GPU_SUPPORT}) | ||
| - find_package(OpenSubdiv 3 REQUIRED) | ||
| + find_package(OpenSubdiv 3 CONFIG REQUIRED) | ||
| + set(OPENSUBDIV_LIBRARIES OpenSubdiv::osdCPU_static) | ||
| + set(OPENSUBDIV_OSDCPU_LIBRARY OpenSubdiv::osdCPU_static) # For compatibility | ||
| + if(PXR_ENABLE_GL_SUPPORT) | ||
| + list(APPEND OPENSUBDIV_LIBRARIES OpenSubdiv::osdGPU_static) | ||
| + endif() | ||
| # --Ptex | ||
| if (PXR_ENABLE_PTEX_SUPPORT) | ||
| find_package(PTex REQUIRED) | ||
| diff --git a/pxr/imaging/hgiVulkan/CMakeLists.txt b/pxr/imaging/hgiVulkan/CMakeLists.txt | ||
| index 97e4228..3eb83be 100644 | ||
| --- a/pxr/imaging/hgiVulkan/CMakeLists.txt | ||
| +++ b/pxr/imaging/hgiVulkan/CMakeLists.txt | ||
| @@ -46,8 +46,6 @@ pxr_library(hgiVulkan | ||
| api.h | ||
| vulkan.h | ||
|
|
||
| - PRIVATE_CLASSES | ||
| - spirv_reflect | ||
|
|
||
| RESOURCE_FILES | ||
| plugInfo.json | ||
| diff --git a/pxr/imaging/plugin/hioOiio/CMakeLists.txt b/pxr/imaging/plugin/hioOiio/CMakeLists.txt | ||
| index 0a055b7..de4b73a 100644 | ||
| --- a/pxr/imaging/plugin/hioOiio/CMakeLists.txt | ||
| +++ b/pxr/imaging/plugin/hioOiio/CMakeLists.txt | ||
| @@ -7,6 +7,7 @@ if (NOT ${PXR_BUILD_GPU_SUPPORT}) | ||
| return() | ||
| endif() | ||
|
|
||
| +if(0) # No need because OpenImageIO::OpenImageIO already declare its transitive dependencies correctly | ||
| # Use the import targets set by Imath's package config | ||
| if (Imath_FOUND) | ||
| set(__OIIO_IMATH_LIBS "Imath::Imath") | ||
| @@ -14,6 +15,7 @@ else() | ||
| set(__OIIO_IMATH_INCLUDE ${OPENEXR_INCLUDE_DIRS}) | ||
| set(__OIIO_IMATH_LIBS ${OPENEXR_LIBRARIES}) | ||
| endif() | ||
| +endif() | ||
|
|
||
| pxr_plugin(hioOiio | ||
| LIBRARIES | ||
| diff --git a/pxr/pxrConfig.cmake.in b/pxr/pxrConfig.cmake.in | ||
| index 041cd8c..2f89d69 100644 | ||
| --- a/pxr/pxrConfig.cmake.in | ||
| +++ b/pxr/pxrConfig.cmake.in | ||
| @@ -20,6 +20,27 @@ include(CMakeFindDependencyMacro) | ||
|
|
||
| find_dependency(TBB CONFIG) | ||
|
|
||
| +if(@PXR_BUILD_IMAGING@) | ||
| + find_dependency(OpenSubdiv 3 CONFIG) | ||
| + if(@PXR_BUILD_OPENIMAGEIO_PLUGIN@) | ||
| + find_dependency(OpenImageIO CONFIG) | ||
| + endif() | ||
| + if(@PXR_ENABLE_GL_SUPPORT@) | ||
| + find_dependency(OpenGL REQUIRED) | ||
| + endif() | ||
| + if(@PXR_ENABLE_VULKAN_SUPPORT@) | ||
| + if (NOT DEFINED Vulkan_DIR) | ||
| + if (NOT [[@Vulkan_DIR@]] STREQUAL "") | ||
| + set(Vulkan_DIR [[@Vulkan_DIR@]]) | ||
| + endif() | ||
| + endif() | ||
| + find_dependency(Vulkan REQUIRED) | ||
| + find_dependency(unofficial-shaderc CONFIG) | ||
| + find_dependency(unofficial-spirv-reflect CONFIG) | ||
| + find_dependency(VulkanMemoryAllocator CONFIG) | ||
| + endif() | ||
| +endif() | ||
| + | ||
| # If Python support was enabled for this USD build, find the import | ||
| # targets by invoking the appropriate FindPython module. Use the same | ||
| # LIBRARY and INCLUDE_DIR settings from the original build if they | ||
| @@ -75,17 +96,17 @@ if(@Imath_FOUND@) | ||
| set(Imath_DIR [[@Imath_DIR@]]) | ||
| endif() | ||
| endif() | ||
| - find_dependency(Imath) | ||
| + find_dependency(Imath CONFIG) | ||
| endif() | ||
|
|
||
| -include("${PXR_CMAKE_DIR}/cmake/pxrTargets.cmake") | ||
| +include("${PXR_CMAKE_DIR}/pxrTargets.cmake") | ||
| if (TARGET usd_ms) | ||
| set(libs "usd_ms") | ||
| else() | ||
| set(libs "@PXR_ALL_LIBS@") | ||
| endif() | ||
| set(PXR_LIBRARIES "") | ||
| -set(PXR_INCLUDE_DIRS "${PXR_CMAKE_DIR}/include") | ||
| +set(PXR_INCLUDE_DIRS "${PXR_CMAKE_DIR}/../../include") | ||
| string(REPLACE " " ";" libs "${libs}") | ||
| foreach(lib ${libs}) | ||
| get_target_property(location ${lib} LOCATION) |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.