-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[qt] Enable android #42080
base: master
Are you sure you want to change the base?
[qt] Enable android #42080
Conversation
@m-kuhn Elapsed time to handle qtbase:x64-android: 4.2 min |
This comment was marked as outdated.
This comment was marked as outdated.
c1181b6
to
4a69582
Compare
qtbase 6.7 silently overrides toolchain API level 21 with actual API level 23. qtbase also selects |
if(VCPKG_TARGET_IS_ANDROID) | ||
# Qt requires libc++_shared, cf. <qtbase>/cmake/QtPlatformAndroid.cmake | ||
# and https://developer.android.com/ndk/guides/cpp-support#sr | ||
vcpkg_check_linkage(ONLY_DYNAMIC_CRT) | ||
endif() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modeling what is hard-coded in Qt.
Excludes it from vcpkg CI with its current Android configuration.
FYI, #42165 changes the Docker base image for Android to 24.04 "Noble". |
Fine, but there is not much impact on Android. Can you add ruby now, as in the linux image? Some ports do (We might also use openjdk from the system packages.) |
qtbase and gdal passing now 🎉 |
I suggest to continue with moving vcpkg android CI to this configuration. Probably using new triplets |
bb50a03
to
256a039
Compare
Tagging with vm-update so I remember to mint you a new Docker image with the changes here after #42749 |
Oops, I forgot anyway. I blame getting COVID that week :( . Doing patch tuesday stuff for this month now and will look at minting one of these for you this week. |
No problem, I probably need a moment to sort the commits. Xmas wasn't enough time for that. What also needs to be discussed:
Cf. https://github.com/microsoft/vcpkg/pull/42080/files#r1836012959 |
I believe the vm-update parts have landed last month |
Ouch. |
In vcpkg_cmake_configure, it is a cache variable.
This reverts commit 7e6dca2.
qtbase:arm64-osx=pass | ||
qtbase:x64-osx=pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be obsolete with #44555.
Reprise from #35845.
Dependencies: