Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change tool SHAs to lowercase. #43164

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

BillyONeal
Copy link
Member

This is a 'quick and dirty workaround' for a customer who depended on our x-script SHAs in asset caching being lowercase.

The real fix is microsoft/vcpkg-tool#1564 , but this is a change they can use before we can get a tool release out the door.

This is a 'quick and dirty workaround' for a customer who depended on our x-script SHAs in asset caching being lowercase.

The real fix is microsoft/vcpkg-tool#1564 , but this is a change they can use before we can get a tool release out the door.
@BillyONeal BillyONeal added category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) info:internal This PR or Issue was filed by the vcpkg team. labels Jan 8, 2025
Copy link
Contributor

@WangWeiLin-MV WangWeiLin-MV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check passed by cat scripts/vcpkgTools.xml | grep '<sha512>' | grep '[A-Z]'

@WangWeiLin-MV WangWeiLin-MV added the info:reviewed Pull Request changes follow basic guidelines label Jan 8, 2025
@BillyONeal BillyONeal merged commit c9e4056 into microsoft:master Jan 8, 2025
17 checks passed
@BillyONeal BillyONeal deleted the tolower-tools-xml branch January 8, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants