Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg scripts] Changing case of SHA #43273

Closed

Conversation

rishabh290598
Copy link

This is a workaround for a customer who depended on our x-script SHAs in asset caching being lowercase.

@MonicaLiu0311 MonicaLiu0311 changed the title Changing case of SHA [vcpkg scripts] Changing case of SHA Jan 15, 2025
@MonicaLiu0311 MonicaLiu0311 added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Jan 15, 2025
@wilyle
Copy link

wilyle commented Jan 15, 2025

This seems related to microsoft/vcpkg-tool#1564 which was supposed to use lowercase SHAs. Looks like however this package is configured/retrieved doesn't use the same code path so this might indicate a bug with that change.

@BillyONeal
Copy link
Member

Unlike the one in vcpkgTools.xml changing this one will invalidate binary caches for all Linux customers so it would be better to make this change in vcpkg.exe.

@BillyONeal
Copy link
Member

microsoft/vcpkg-tool#1574

@MonicaLiu0311
Copy link
Contributor

@rishabh290598 This PR will be closed soon, thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants