[vcpkg scripts] Changing case of SHA #43273
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MonicaLiu0311
changed the title
MonicaLiu0311
added
the
category:tool-update
|
This seems related to microsoft/vcpkg-tool#1564 which was supposed to use lowercase SHAs. Looks like however this package is configured/retrieved doesn't use the same code path so this might indicate a bug with that change. |
|
Unlike the one in vcpkgTools.xml changing this one will invalidate binary caches for all Linux customers so it would be better to make this change in vcpkg.exe. |
|
@rishabh290598 This PR will be closed soon, thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for a customer who depended on our x-script SHAs in asset caching being lowercase.