[tracy] update to 0.13

[Francisco Facioni (fran6co)]

Fixes #48105
Fixes #45820
Fixes #49750
Fixes #49197

• Changes comply with the maintainer guide.
• SHA512s are updated for each updated download.
• The "supports" clause reflects platforms that may be fixed by this new version.
• Any fixed CI baseline entries are removed from that file.
• Any patches that are no longer applied are deleted from the port's directory.
• The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
• Only one version is added to each modified port's versions file.

[Francisco Facioni (fran6co)]

For some reason in windows it can't find the patch executable, is there a good way to deal with that?

[Kai Pastor (dg0yt)]

For some reason in windows it can't find the patch executable, is there a good way to deal with that?

I would take this as a hint that it does something which it shouldn't do anyways:
What would it patch if not (sources of) vendored dependencies?

But the log show that it fails to find GIT_EXECUTABLE. This could be fixed easily. However it also shouldn't use git to download vendored dependencies...

[Francisco Facioni (fran6co)]

It's getting imgui source code and patching it, vendoring imgui for this case I think it might be tricky as it's adding stuff to it

[Kai Pastor (dg0yt)]

It's getting imgui source code and patching it, vendoring imgui for this case I think it might be tricky as it's adding stuff to it

I don't know if the vendored copy will be accepted.
But it might be necessary to at least pull download and patching out of the CMake project into the portfile.
Then the download could go through proper asset caching, and the vendored source would be obvious to reviewers. And you could add comments as needed.

[Kai Pastor (dg0yt)]

A vendored imgui might be more acceptable if it is only used by executables, not libraries.

[Francisco Facioni (fran6co)]

imgui is only used by the executables when using gui-tools, the lib itself doesn't depend on imgui

[Francisco Facioni (fran6co)]

doing outside the cmake would require to always sync up on every tracy new version, if I could get windows to just find the patch binary for CPM to work then it would just work like the other platforms

[Kai Pastor (dg0yt)]

doing outside the cmake would require to always sync up on every tracy new version, if I could get windows to just find the patch binary for CPM to work then it would just work like the other platforms

The portfile must do the downloads.

[Josef Šimánek (simi)]

Anything I can help with?

[Francisco Facioni (fran6co)]

I don't have time to figure out the issue and/or move the downloading and patching of imgui to the portfile. The easy solution of making the windows builds to find the patch.exe seems not the accepted solution

[Kai Pastor (dg0yt)]

I prefer to see CPM ripped out where it is used instead of forcing changes to dependencies.

[Billy O'Neal (BillyONeal)]

I'm not sure if we can take this given that it is trying to vendor imgui. On the other hand it may have already been doing that before?

[Tom Conder (tomconder)]

This looks good. imgui-loader.patch can be removed since you now use tracy's patch.

[Francisco Facioni (fran6co)]

This looks good. imgui-loader.patch can be removed since you now use tracy's patch.

I can't because their patch doesn't work using vcpkg patches for some reason, that's why I had to patch the patch

[Francisco Facioni (fran6co)]

ah, sorry.. you are correct

[Francisco Facioni (fran6co)]

Done

[Tom Conder (tomconder)]

When I install the gui-tools feature -- vcpkg install tracy[core,gui-tools] -- it creates a GitRef.hpp with extra-quotes which fails the build. I believe this is an existing problem with tracy, not introduced by this PR.

I made a patch to fix the GitRef.hpp generation. It uses configure_file() instead of a custom command. See https://github.com/tomconder/vcpkg/blob/tracy/ports/tracy/fix-gitref.patch

[Francisco Facioni (fran6co)]

Weird, I'm not having that issue and the CI chugged along. In any case I'm pushing the patch anyways

[Tom Conder (tomconder)]

Weird, I'm not having that issue and the CI chugged along. In any case I'm pushing the patch anyways

Applying the patch fixed my build and install. I appreciate it. 🙂

[Tom Conder (tomconder)]

You have been accomodating. Can I request a change to the fix-gitref.patch file? After some testing I found that git needs to be called as ${GIT_EXECUTABLE}.

So line 16 of fix-gitref.patch should be:

+        COMMAND ${GIT_EXECUTABLE} log -1 --format=%h ${GIT_REV}

instead of

+        COMMAND git log -1 --format=%h ${GIT_REV}

[Francisco Facioni (fran6co)]

No prob, done

[Billy O'Neal (BillyONeal)]

Thanks for the update!