[clfml-lowwi] Fix build failure: Disable examples and correct installation paths #49618
Conversation
|
@microsoft-github-policy-service agree |
| SOURCE_PATH "${SOURCE_PATH}" | ||
| OPTIONS | ||
| "-DCLFML_LOWWI_BUILD_EXAMPLE_PROJECTS=OFF" # <--- YE HAI SOLUTION (No Examples = No SDL2 Download) | ||
| "-DFETCHCONTENT_FULLY_DISCONNECTED=OFF" # Onnx ke liye internet on rakha hai |
There was a problem hiding this comment.
No. vcpkg intentionally sets FETCHCONTENT_FULLY_DISCONNECTED to prevent vendoring of dependencies. If possible, replace the necessary dependencies with vcpkg ports; if no port exists, then explicitly acquire the dependencies as part of the portfile.
| ) | ||
|
|
||
| # 2. Build Only | ||
| vcpkg_cmake_build() |
There was a problem hiding this comment.
Use vcpkg_cmake_install() if the upstream CMakeLists.txt does not have install targets then we would prefer to patch it so it does.
| @@ -0,0 +1,13 @@ | |||
| { | |||
| "name": "clfml-lowwi", | |||
| "version": "3.0", | |||
There was a problem hiding this comment.
This PR is missing version database files, please run vcpkg x-add-version clfml-lowwi and commit the results.
| # B. Libraries copy karo (Release) | ||
| file(GLOB_RECURSE REL_LIB "${CURRENT_BUILDTREES_DIR}/${TARGET_TRIPLET}-rel/*.lib") | ||
| file(INSTALL ${REL_LIB} DESTINATION "${CURRENT_PACKAGES_DIR}/lib") |
There was a problem hiding this comment.
| # B. Libraries copy karo (Release) | |
| file(GLOB_RECURSE REL_LIB "${CURRENT_BUILDTREES_DIR}/${TARGET_TRIPLET}-rel/*.lib") | |
| file(INSTALL ${REL_LIB} DESTINATION "${CURRENT_PACKAGES_DIR}/lib") | |
| # B. Libraries copy karo (Release) | |
| if (NOT VCPKG_BUILD_TYPE OR VCPKG_BUILD_TYPE STREQUAL "release") | |
| file(GLOB_RECURSE REL_LIB "${CURRENT_BUILDTREES_DIR}/${TARGET_TRIPLET}-rel/*.lib") | |
| file(INSTALL ${REL_LIB} DESTINATION "${CURRENT_PACKAGES_DIR}/lib") | |
| endif() |
But it would be really preferable if you could patch CMakeLists.txt so that we can do vcpkg_cmake_install
| file(GLOB_RECURSE DBG_LIB "${CURRENT_BUILDTREES_DIR}/${TARGET_TRIPLET}-dbg/*.lib") | ||
| file(INSTALL ${DBG_LIB} DESTINATION "${CURRENT_PACKAGES_DIR}/debug/lib") |
There was a problem hiding this comment.
| file(GLOB_RECURSE DBG_LIB "${CURRENT_BUILDTREES_DIR}/${TARGET_TRIPLET}-dbg/*.lib") | |
| file(INSTALL ${DBG_LIB} DESTINATION "${CURRENT_PACKAGES_DIR}/debug/lib") | |
| if (NOT VCPKG_BUILD_TYPE OR VCPKG_BUILD_TYPE STREQUAL "debug") | |
| file(GLOB_RECURSE DBG_LIB "${CURRENT_BUILDTREES_DIR}/${TARGET_TRIPLET}-dbg/*.lib") | |
| file(INSTALL ${DBG_LIB} DESTINATION "${CURRENT_PACKAGES_DIR}/debug/lib") | |
| endif() |
Same as above, it would be better to use vcpkg_cmake_install
2 participants
Fixed build failure for
clfml-lowwion windows-x64.Changes:
CMakeLists.txtvia portfile to prevent configuration errors and race conditions.vcpkg.jsonto properly configureonnxruntimedependency.portfile.cmaketo handle header files and dependencies correctly (manual install).