[qtmultimedia] Fix build with FFMPEG 8.x on Android. #49685
Draft
+36
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes this build error:
```console
/mnt/vcpkg-ci/b/qtmultimedia/src/here-src-6-8440b54a87.clean/src/plugins/multimedia/ffmpeg/recordingengine/qffmpegencoderoptions.cpp:317:26: error: use of undeclared identifier 'FF_PROFILE_H264_HIGH'
317 | codec->profile = FF_PROFILE_H264_HIGH;
| ^
/mnt/vcpkg-ci/b/qtmultimedia/src/here-src-6-8440b54a87.clean/src/plugins/multimedia/ffmpeg/recordingengine/qffmpegencoderoptions.cpp:329:26: error: use of undeclared identifier 'FF_PROFILE_HEVC_MAIN'
329 | codec->profile = FF_PROFILE_HEVC_MAIN;
| ^
2 errors generated.
```
FFMPEG appears to have renamed `FF_PROFILE_Xxx` to `AV_PROFILE_Xxx` in FFmpeg/FFmpeg@8238bc0
See also microsoft#48539
Member
Author
|
I cancelled the build because the qt maintainers have jumped on this quickly: https://codereview.qt-project.org/c/qt/qtmultimedia/+/708519 We should take their patch instead of mine; I'm going to wait a bit and see if that lands Soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this build error:
FFMPEG appears to have renamed
FF_PROFILE_XxxtoAV_PROFILE_Xxxin FFmpeg/FFmpeg@8238bc0See also #48539
Submitted upstream: https://qt-project.atlassian.net/browse/QTBUG-143747