[ltla-cppirlba] Update to 3.1.0 [libscran-umappp] Update to 3.3.0#51202
[ltla-cppirlba] Update to 3.1.0 [libscran-umappp] Update to 3.3.0#51202BillyONeal merged 6 commits intomicrosoft:masterfrom
Conversation
CC @LTLA |
|
I'd suggest holding off until I update umappp. |
|
@xiaozhuai Thanks for looking at the issues, I'm experimenting with using Copilot to generate reports on PR test failures. For comparison this is what the analyze-ci-failures skill found out using Claude Opus 4.6: vcpkg CI Failure Report — Build #130079Build: #130079 Summary
Total unique failing ports across all triplets: 1 ( 🔴 New Regressions (Action Required)1.
|
I think this suggested fix is bogus because vcpkg doesn't support |
|
@LTLA Thank you for updating umappp. This PR can now move forward. |
| find_dependency(ltla_sanisizer 0.2.0 CONFIG REQUIRED) | ||
| find_dependency(ltla_subpar 0.5.0 CONFIG REQUIRED) | ||
| find_dependency(ltla_irlba 3.0.0 CONFIG REQUIRED) | ||
| find_dependency(ltla_irlba 3.1.0 CONFIG REQUIRED) |
There was a problem hiding this comment.
find_dependency must not be REQUIRED. I submitted libscran/umappp#35 .
|
@BillyONeal Thank you for the patch! |
./vcpkg x-add-version --alland committing the result.