[vcpkg-tool-meson] Fixes for additional languages#51492
Open
ajtribick wants to merge 1 commit intomicrosoft:masterfrom
Open
[vcpkg-tool-meson] Fixes for additional languages#51492ajtribick wants to merge 1 commit intomicrosoft:masterfrom
ajtribick wants to merge 1 commit intomicrosoft:masterfrom
Conversation
- Match the template and variable names for Objective-C++ - Use ADDITIONAL_LANGUAGES parameter for vcpkg_cmake_get_vars
Member
|
@abique Can you confirm that this works? I'm reluctant to merge something for a bug for which we do not have a repro and we don't have a clear understanding of what happened. |
Contributor
Author
|
It would also be useful to know whether this works with glib as well as harfbuzz. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
./vcpkg x-add-version --alland committing the result.Relevant: #51404 (but I can't check whether this actually fixes it)
Please double-check this! In particular, I have absolutely no idea why the existing method of passing additional languages for Meson works with glib and not with harfbuzz! From what I can see based on local testing, using the ADDITIONAL_LANGUAGES parameter works for both.
Since I don't have any platforms that actually build the Objective-C/C++ code, I have verified this by the entries being created in the meson-${platform}-dbg.log files.