[netgen] Fix dependencies.#51494
Open
BillyONeal wants to merge 12 commits intomicrosoft:masterfrom
Open
Conversation
In microsoft#51419 we see netgen:x64-android fails due to ``` CMake Error at /vcpkg/downloads/tools/cmake-4.2.3-linux/cmake-4.2.3-linux-x86_64/share/cmake-4.2/Modules/FindPackageHandleStandardArgs.cmake:290 (message): Could NOT find Fontconfig (missing: Fontconfig_LIBRARY Fontconfig_INCLUDE_DIR) Call Stack (most recent call first): /vcpkg/downloads/tools/cmake-4.2.3-linux/cmake-4.2.3-linux-x86_64/share/cmake-4.2/Modules/FindPackageHandleStandardArgs.cmake:654 (_FPHSA_FAILURE_MESSAGE) /vcpkg/downloads/tools/cmake-4.2.3-linux/cmake-4.2.3-linux-x86_64/share/cmake-4.2/Modules/FindFontconfig.cmake:99 (find_package_handle_standard_args) /vcpkg/scripts/buildsystems/vcpkg.cmake:908 (_find_package) CMakeLists.txt:405 (find_package) ``` Initial test of a PR build run testing just that port to see if it's broken in the baseline (it is not broken in CI builds but they may have just happened to install fontconfig first)
7 tasks
BillyONeal
changed the title
BillyONeal
commented
May 2, 2026
Member
Author
|
…compiling pitfalls for python. This change was authored by GPT 5.4.
xiaozhuai
reviewed
May 3, 2026
Contributor
There was a problem hiding this comment.
A file that shouldn't be there?
xiaozhuai
reviewed
May 3, 2026
Contributor
There was a problem hiding this comment.
A file that shouldn't be there?
vicroms
requested changes
May 3, 2026
Member
vicroms
left a comment
vicroms
left a comment
There was a problem hiding this comment.
Installation output found its way into the PR.
Member
|
Time to make it a post build check. |
Member
Author
Unfortunately we explicitly do the opposite right now. When we apply patches with git we explicitly give it flags to ignore line ending bits, probably as fallout from when we often used PowerShell |
BillyONeal
commented
May 4, 2026
| netcdf-cxx4:arm64-windows-static-md=fail | ||
| netcdf-cxx4:x64-windows-static-md=fail | ||
| netgen[python]:arm64-linux=cascade | ||
| netgen[core,cgns,jpeg,mpeg,occ,python]:arm64-linux=combination-fails |
Member
Author
There was a problem hiding this comment.
I figure the number of tests that work has not actually changed from this ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #51419 we see netgen:x64-android fails due to
Initial test of a PR build run testing just that port to see if it's broken in the baseline (it is not broken in CI builds but they may have just happened to install fontconfig first)