[dpdk] Disable optional dependencies. by BillyONeal · Pull Request #51495 · microsoft/vcpkg

BillyONeal · 2026-05-01T23:48:33Z

This fixes the CI failures https://dev.azure.com/vcpkg/public/_build/results?buildId=130806&view=results caused by optionally grabbing jansson which exposes unsupported C99 VLAs to MSVC.

Also regenerated all patches where the line numbers changed.

This fixes the CI failures https://dev.azure.com/vcpkg/public/_build/results?buildId=130806&view=results caused by optionally grabbing jansson which exposes unsupported C99 VLAs to MSVC. Also regenerated all patches where the line numbers changed. Co-authored-by: Copilot <copilot@github.com>

BillyONeal · 2026-05-01T23:49:02Z

 endif

+ has_libfdt = false
+-fdt_dep = cc.find_library('fdt', required: false)


I am not sure about some of these but they're dependencies not in vcpkg.json.

AFAICT, libfdt is required to build the IFPGA Rawdev Driver, and the IPN3KE Poll Mode Driver. These drivers may well be important to a user of DPDK, depending on their use-case, and the devices they are looking to interact with.

AFAICT, libfdt is required to build the IFPGA Rawdev Driver, and the IPN3KE Poll Mode Driver. These drivers may well be important to a user of DPDK, depending on their use-case, and the devices they are looking to interact with.

Then the port needs to be fixed to arrange for those dependencies to be present.

AFAIU the patch arranges for the package to not offer this capability. This is fine. No installation order dependency.

It's fine from vcpkg's perspective but I'm not sure it's fine from dpdk users' perspective. For some of these vcpkg already has the dependency available and I could resolve it the other way (always turn the dependency on).

BillyONeal · 2026-05-01T23:49:40Z

+ endif
+
+ # check for OpenSSL
+-openssl_dep = dependency('openssl', required: false, method: 'pkg-config')


The correct change may be to add openssl as a dependency instead?

AFAICT, openssl is used by the OpenSSL Crypto Poll Mode Driver, and within examples.

BillyONeal · 2026-05-01T23:51:47Z

@kreuzerkrieg @Rastaban @vicroms @ras0219-msft @ljishen
@chris1786 @autoantwort @dg0yt @bansan85 @SunBlack Tagging you in case you want to review because you have touched this port before.

BillyONeal · 2026-05-01T23:53:11Z


 # Add a leading zero to the minor version if it consists of only one digit, otherwise the regex does nothing
-string(REGEX REPLACE "^([0-9]+)\\.([0-9])(\\..*)$" "\\1.0\\2\\3" VERSION_REF "${VERSION}")
+# Match both `X.Y` and `X.Y.Z...` forms (optional remainder).


That this was wrong and nobody noticed suggests that people don't actually care about this port :(

Is this transformation even desirable? Would it not be preferable to store the canonical version, as defined by the dpdk project, within dpdk.json?

I only added the regex in the last update, and during the last adjustment, I must have forgotten to make the group optional after I hadn't forced the period in the group at first ;-). So this issue is in this repo only since 5 days ;-)

Is this transformation even desirable? Would it not be preferable to store the canonical version, as defined by the dpdk project, within dpdk.json?

Desirable, yes. However, there is no suitable version scheme in vcpkg which allows 26.04 without loosing comparing for <.

Copilot

Pull request overview

This PR updates the dpdk vcpkg port to avoid non-deterministic optional dependency discovery (notably jansson) that breaks MSVC CI, and bumps the port version accordingly.

Changes:

Bump dpdk to port-version: 1 and update the versions database/baseline.
Adjust the tag REF formatting logic in portfile.cmake to handle both X.Y and X.Y.Z... version forms.
Regenerate/update the DPDK patch set (including disabling several optional Meson dependencies to prevent accidental pickup from the environment).

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
versions/d-/dpdk.json	Adds the new `26.3#1` git-tree entry.
versions/baseline.json	Bumps the `dpdk` baseline port-version to `1`.
ports/dpdk/vcpkg.json	Bumps port-version to `1`.
ports/dpdk/portfile.cmake	Updates version tag normalization regex used for `vcpkg_from_github(REF ...)`.
ports/dpdk/0001-enable-either-static-or-shared-build.patch	Patch regenerated (offset/index updates).
ports/dpdk/0002-fix-dependencies.patch	Disables optional Meson deps (e.g., jansson) to avoid unintended discovery; other adjustments retained.
ports/dpdk/0003-remove-examples-src-from-datadir.patch	Patch regenerated (offset/index updates).
ports/dpdk/0004-stop-building-apps.patch	Patch regenerated (offset/index updates).
ports/dpdk/0005-no-absolute-driver-path.patch	Patch regenerated (offset/index updates).
ports/dpdk/0006-rename-sched.h.patch	Patch regenerated (offset/index updates).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

BillyONeal · 2026-05-02T00:10:13Z

+ pcap_lib = is_windows ? 'wpcap' : 'pcap'
+ if not pcap_dep.found()
+     # pcap got a pkg-config file only in 1.9.0
+-    pcap_dep = cc.find_library(pcap_lib, required: false)
+    pcap_dep = disabler()


That would make the patch longer so I do not want to do that.

chris1786 · 2026-05-02T13:43:07Z

@kreuzerkrieg @Rastaban @vicroms @ras0219-msft @ljishen @chris1786 @autoantwort @dg0yt @bansan85 @SunBlack Tagging you in case you want to review because you have touched this port before.

I've added several comments, which hopefully add some context, although I will caveat this by saying that I am far from a dpdk expert. My experience of using this port, is that it currently pulls many of the dependencies it requires to build its drivers implicitly from the system on which it is built. This doesn't seem ideal, but probably requires substantial effort to resolve. I'd be wary of disabling dependencies entirely; this is likely to limit the utility of this port, as having the correct drivers available is key to being able to use dpdk effectively.

chris1786 · 2026-05-02T12:59:38Z


 # Add a leading zero to the minor version if it consists of only one digit, otherwise the regex does nothing
-string(REGEX REPLACE "^([0-9]+)\\.([0-9])(\\..*)$" "\\1.0\\2\\3" VERSION_REF "${VERSION}")
+# Match both `X.Y` and `X.Y.Z...` forms (optional remainder).


Is this transformation even desirable? Would it not be preferable to store the canonical version, as defined by the dpdk project, within dpdk.json?

chris1786 · 2026-05-02T13:13:19Z

 endif

+ has_libfdt = false
+-fdt_dep = cc.find_library('fdt', required: false)


AFAICT, libfdt is required to build the IFPGA Rawdev Driver, and the IPN3KE Poll Mode Driver. These drivers may well be important to a user of DPDK, depending on their use-case, and the devices they are looking to interact with.

chris1786 · 2026-05-02T13:16:35Z

+
+ # check for libbsd
+-libbsd = dependency('libbsd', required: false, method: 'pkg-config')
+libbsd = disabler()


AFAICT, removing the dependency on libbsd won't disable any functionality.

chris1786 · 2026-05-02T13:25:04Z

+ endif
+
+-jansson_dep = dependency('jansson', required: false, method: 'pkg-config')
+jansson_dep = disabler()


jansson appears to be used to support telemetry, and enables optional functionality in a number of drivers.

The problem is that as currently set up it makes things path dependent. That is,

vcpkg install jansson vcpkg install dpdk

gives a totally different result than

vcpkg install dpdk vcpkg install jansson

which is why the most recent dpdk update PR landed fine but we have not seen a clean world rebuild since, because jansson happened to get installed first and trigger incompatibilities with MSVC.

The question for purposes of this PR to restore nightly runs is not "would someone like when these optional dependencies are used", but "is the port completely broken for all purposes and we need to try to get vcpkg to provide them instead".

AFAIU the patch arranges for the package to not offer this capability. This is fine. No installation order dependency.

chris1786 · 2026-05-02T13:31:25Z

+ endif
+
+ # check for OpenSSL
+-openssl_dep = dependency('openssl', required: false, method: 'pkg-config')


AFAICT, openssl is used by the OpenSSL Crypto Poll Mode Driver, and within examples.

chris1786 · 2026-05-02T13:38:11Z

+
+ # check for pcap
+-pcap_dep = dependency('libpcap', required: false, method: 'pkg-config')
+pcap_dep = disabler()


AFAICT, libpcap is required by the Pcap Poll Mode Driver, and to enable several other pieces of optional functionality

chris1786 · 2026-05-03T22:28:10Z

It's worth noting that this port also has several implicit uncontrolled dependencies specified within the drivers directory. Three library dependencies that I'm aware of are libibverbs, libmlx4, and libmlx5. These are provided by rdma-core, which I've created a port for in this PR.

There are undoubtedly other uncontrolled dependencies.

BillyONeal commented May 1, 2026

View reviewed changes

BillyONeal requested a review from Copilot May 1, 2026 23:52

Copilot started reviewing on behalf of BillyONeal May 1, 2026 23:52 View session

BillyONeal commented May 1, 2026

View reviewed changes

Copilot AI reviewed May 1, 2026

View reviewed changes

Fix pkgconfig?

88534e7

chris1786 reviewed May 2, 2026

View reviewed changes

Conversation

BillyONeal commented May 1, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BillyONeal commented May 1, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chris1786 commented May 2, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chris1786 commented May 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants