[joltphysics] Add shared lib as build option - #53317
[joltphysics] Add shared lib as build option#53317Bruno S Marques (bmarques1995) wants to merge 1 commit into
Conversation
|
In general, please try to avoid closing and reopening PRs with the same content, it makes following comments back to where they came from difficult. In addition, GPT 5.6 Sol reports:
Would you consider merging bmarques1995#1 ? |
8a6057a to
5314c10
Compare
Okay, i tried to merge the changes, bad idea |
Kai Pastor (dg0yt)
left a comment
There was a problem hiding this comment.
Upstream JPH_BUILD_SHARED_LIBS defaults to BUILD_SHARED_LIBS, so the extra option is not needed at all after changing vcpkg_check_linkage.
https://github.com/jrouwe/JoltPhysics/blob/e77f175595e64cb44218cc9d9d56fc365ad0e36a/Build/CMakeLists.txt#L30
| ) | ||
|
|
||
| string(COMPARE EQUAL "${VCPKG_CRT_LINKAGE}" "static" USE_STATIC_CRT) | ||
| string(COMPARE EQUAL "${VCPKG_LIBRARY_LINKAGE}" "dynamic" JPH_BUILD_SHARED_LIBS) |
There was a problem hiding this comment.
| string(COMPARE EQUAL "${VCPKG_LIBRARY_LINKAGE}" "dynamic" JPH_BUILD_SHARED_LIBS) |
| -DTARGET_VIEWER=OFF | ||
| -DCROSS_PLATFORM_DETERMINISTIC=OFF | ||
| -DINTERPROCEDURAL_OPTIMIZATION=OFF | ||
| -DJPH_BUILD_SHARED_LIBS=${JPH_BUILD_SHARED_LIBS} |
There was a problem hiding this comment.
| -DJPH_BUILD_SHARED_LIBS=${JPH_BUILD_SHARED_LIBS} |
Continues #53241