[Throwaway POC] Potential fix for supportsVision undefined#4888
Draft
[Throwaway POC] Potential fix for supportsVision undefined#4888
supportsVision undefined#4888Conversation
supportsVision undefinedsupportsVision undefined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was seeing issues like
TypeError: Cannot read properties of undefined (reading 'supportsVision')in logs when running local evals, so I asked Copilot to investigate and it suggested this fix. I asked copilot to come up with a PR description, and this is what it said:Title: Fix crash in sendInvokedToolTelemetry when tool result contains images
Description:
When a tool (e.g.
view_image) returns an image in its result,sendInvokedToolTelemetrycrashes with:Root cause:
sendInvokedToolTelemetrycreates a bareBasePromptRendererto count tokens, but does not registerIPromptEndpointin the DI container. When the tool result contains aLanguageModelDataPartimage,PrimitiveToolResult.render()callsonImage(), which accessesthis.endpoint.supportsVision— butthis.endpointisundefinedbecause it was never injected.Fix: Filter out image data parts before passing the tool result content to
PrimitiveToolResult. Image blobs are binary data that don't contribute to meaningful token counts, so they should be excluded from this telemetry path.Continued with AutopilotProvided the PR title and description as requested.