Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Enables the Plan agent to include Mermaid diagrams (and use the Mermaid render tool) when explicitly enabled via configuration, keeping Plan-mode output rules consistent across agent generation and the switch-to-Plan tool.
Changes:
- Add
chat.planAgent.mermaid.enabled/github.copilot.chat.planAgent.mermaid.enabledconfiguration and localized description. - Gate Plan agent body instructions + tool list to include Mermaid guidance and the Mermaid render tool only when enabled.
- Add/extend PlanAgentProvider regression tests around Mermaid gating and style-guide rules.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/platform/configuration/common/configurationService.ts | Adds a Plan-specific Mermaid enablement config key. |
| src/extension/tools/vscode-node/switchAgentTool.ts | Switch-to-Plan message now reflects Mermaid guidance based on the setting. |
| src/extension/agents/vscode-node/planAgentProvider.ts | Conditionally injects Mermaid rules + tool, and updates Plan style guide wrapper/rules. |
| src/extension/agents/vscode-node/test/planAgentProvider.spec.ts | Adds regression coverage for Mermaid gating + Plan output rules. |
| package.nls.json | Adds localized setting description. |
| package.json | Exposes the new setting and also changes build scripts to use tsx. |
src/extension/agents/vscode-node/test/planAgentProvider.spec.ts
Outdated
Show resolved
Hide resolved
Replace duplicated conditional string construction for rulesSection with baseRules and mermaidRules arrays, merge them conditionally based on planAgentMermaidEnabled, and join with newlines. This simplifies the logic, improves readability and makes it easier to extend or modify rule lines while preserving the original Mermaid-enabled behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables Mermaid diagrams in Plan mode behind an explicit configuration gate and updates the Plan prompt so Mermaid diagrams are rendered consistently when they materially help a plan.
Key changes:
Refs microsoft/vscode#307804.