Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instrumentation support to the typescript code #12991

Merged
merged 31 commits into from
Feb 26, 2025

Conversation

fearthecowboy
Copy link
Member

This adds the instrumentation support to enable performance testing and monitoring.

It:

  • cleaned up some calls to logging so that we're not over-importing in typescript
  • patches the logging so that log messages are sent to the collector.
  • adds calls to monkey-patch vscode, the client and the providers so that we get monitoring events for as much as possible.
  • if the PERFECTO_LAUNCH_SETTINGS environment variable is not set, everything here is a no-op
  • the actual instrumentation code is loaded by the perfecto tool

@fearthecowboy fearthecowboy requested a review from a team as a code owner November 22, 2024 21:30
Copy link
Contributor

@sean-mcmanus sean-mcmanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the instrument be added for vscode.languages.registerCodeActionsProvider in extension.ts?

@sean-mcmanus
Copy link
Contributor

sean-mcmanus commented Feb 26, 2025

FYI, a copilotCompletionProvider got added recently, but I don't know how you would handle that with instrument.

Maybe here?

            this.contextProviderDisposable = contextAPI.registerContextProvider({
                id: CopilotCompletionContextProvider.providerId,
                selector: CopilotCompletionContextProvider.defaultCppDocumentSelector,
                resolver: this
            });

@fearthecowboy fearthecowboy merged commit a2b7383 into main Feb 26, 2025
6 checks passed
@fearthecowboy fearthecowboy deleted the dev/garretts/instrumentation branch February 26, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants