Fix PDF export file path handling #16594
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16590
Fixes the long-standing bug where exporting a Jupyter notebook to PDF via the VS Code Jupyter extension fails, even though the PDF is correctly generated in the temp directory. The extension was looking for the wrong filename (missing or duplicating the
.pdf
extension), resulting in a file-not-found error and failed export.Background and Motivation
nbconvert
), only in the VS Code extension.Root Cause
tmp-xxxx.pdf
), but then tries to access or copy a file with an incorrect name (e.g.,tmp-xxxx.pdf.pdf
or missing.pdf
).src/notebooks/export/exportBase.node.ts
:What has been changed
Additional context
Closes #16590